search

viesti / timbre-json-appender

JSON appender for Timbre
MIT License
44 stars 11 forks source link

add with-context handler as per viesti/timbre-json-appender/issues/8#… #9

Closed xlfe closed 3 years ago

xlfe commented 3 years ago

not sure if there is a neater way to do the cond-> with a nested if underneath :D

viesti commented 3 years ago

Looks ok to me, thanks! :)

viesti commented 3 years ago

Ah, just now it occurred to me, that a brief example in README.md might be neat. Feel free to add one :)

xlfe commented 3 years ago

Yes good point. Will do now

On Tue, 3 Nov 2020 at 22:11, Kimmo Koskinen notifications@github.com wrote:

Ah, just now it occurred to me, that a brief example in README.md might be neat. Feel free to add one :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/viesti/timbre-json-appender/pull/9#issuecomment-721052211, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI7ROYKKYQJLJRJQ32LI2DSN7QN5ANCNFSM4TISF5GA .