search

viesturz / klipper-toolchanger

Toolcahnging extension for Klipper
GNU General Public License v3.0
49 stars 16 forks source link

crash_mintime not doing anything? #12

Closed Martorias closed 4 months ago

Martorias commented 4 months ago

It seems the crash detection will instantly fire the crash_gcode regardless of what crash_mintime is set to. I added some debug and could see that the mintime parameter gets pulled from config but even with it set to 5 (seconds?) it's instant. I don't know enough about the klipper reactor and lambda stuff to troubleshoot more deeply myself :-(

Edit: I assume, from reading your comment, the idea is that if the probe triggers then untriggers between now and now+mintime it should return without firing the gcode stuff?

viesturz commented 4 months ago

Hi, thanks for the report. I recall it not working, but never got around to finding the reason. Will take another shot.

On Fri, Apr 12, 2024, 23:07 Martorias @.***> wrote:

It seems the crash detection will instantly fire the crash_gcode regardless of what crash_mintime is set to. I added some debug and could see that the mintime parameter gets pulled from config but even with it set to 5 (seconds?) it's instant. I don't know enough about the klipper reactor and lambda stuff to troubleshoot more deeply myself :-(

— Reply to this email directly, view it on GitHub https://github.com/viesturz/klipper-toolchanger/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMQT46O4K7TQRNFNFY7WKTY5BEHNAVCNFSM6AAAAABGEZCYKSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DAOJRGYZTIMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

viesturz commented 4 months ago

There, working now.

Martorias commented 4 months ago

Awesome, just tested and can confirm the small change fixed it. Thanks!