search

viesturz / klipper-toolchanger

Toolcahnging extension for Klipper
GNU General Public License v3.0
72 stars 22 forks source link

Expose before/after_change_gcode #8

Closed TheSin- closed 5 months ago

TheSin- commented 10 months ago

Expose before_change_gcode and after_change_gcode to allow for user macros.

Example and use in https://github.com/viesturz/tapchanger/pull/25

BrewNinja commented 8 months ago

Any movement on this?

viesturz commented 7 months ago

Finally getting back to this. Let me try yo understand the use case a bit better first, following up in the other PR.

TheSin- commented 7 months ago

It’s okay I started my own fork, i was trying to avoid it be at the rate of commits I had too much of a back log of features, requests and enhancements

viesturz commented 7 months ago

Can you share the fork?

On Mon, Apr 1, 2024, 17:08 Justin F. Hallett @.***> wrote:

It’s okay I started my own fork, i was trying to avoid it be at the rate of commits I had too much of a back log of features, requests and enhancements

— Reply to this email directly, view it on GitHub https://github.com/viesturz/klipper-toolchanger/pull/8#issuecomment-2029913433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMQT4YG7NGO4RPJSCYE4SLY3F2ADAVCNFSM6AAAAABCJL6LXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZHEYTGNBTGM . You are receiving this because you commented.Message ID: @.***>

TheSin- commented 7 months ago

sure it's in the StealthChanger repo, but it's not fit for release yet lots of checks and balances missing ATM, I'm just trying to slowly move through it.

That being said if you are willing to work on these with me I'd MUCH rather not fork, it's confusing for users, but I need to be able to get PRs in a bit quicker (that being said I truly appreciate your review of it and working together we can move it forward quicker).

https://github.com/Stealthchanger/klipper-toolchanger

viesturz commented 7 months ago

Was pretty much out the whole Q1, normally I'm quite responsive. That being said, I'm looking to keep the toolchanger core minimalistic, so depending what you are looking to do, it might be easier to keep things separate with occasional pull requests.

For this PR speficially, it's not clear how the new fields would be used. Right now it's just dead code.

viesturz commented 7 months ago

I reorganized the examples folder, if you are interested to add a Stealthchanger example there.

viesturz commented 5 months ago

Hi, pushed https://github.com/viesturz/klipper-toolchanger/commit/3bfc95b5ede49d6101234ee741f55b824f447506 to address this.