vieten / sequel-pro

Automatically exported from code.google.com/p/sequel-pro
Other
0 stars 0 forks source link

Navigation issue #1149

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Look at Content table with foreign key references that reference to a 
primary key
2. Click Navigation error next to field which indicates (null)
3. Observe empty content table with filter set to IS null and no easy way to 
remove filter

What is the expected output? What do you see instead?

When looking at the content table I can navigate using the arrows from rows in 
my current table to other tables via foreign key constraints. This is a nice 
navigation feature.

However this feature also ALLOWS inappropriate attempts to navigate. The main 
one is if the row contains a null in the foreign key constrained column and I 
am navigating via a foreign key constraint to another table via a primary key 
with NOT NULL set (most frequently this IS the case) then the arrow is not 
going to get me anything in the next table because this is by definition 
impossible without need to even query the table. SO the arrow in the column 
should NOT be displayed for null content in that column, only for non-null 
values.

And this is where the first bug comes in. If I am stupid enough to click on the 
arrow next to the null column it attempts to go to the next table with a IS 
NULL filter. Which gets me no content (duh). The bug is now not only do I have 
no content but there is no easy way to remove the filter like there is with a 
value in the filter bar. The X on the right end of the filter bar is missing 
when the criteria is "IS NULL" so I have to navigate somewhere or change the 
criteria or do something to get rid of the filter for this table.

And here is the subsequent bug - if I have the criteria as IS null and move to 
another table and then back to this table it remembers the filter. Nice 
feature, but recall this is a filter I cannot get rid of easily. IN fact if I 
change the criteria to something else and enter in a value the X pops up to 
allow me to not filter in the filter bar. BUT if you change the filter criteria 
to IS NULL now the value I entered is greyed out AND the X while showing is 
DISABLED!

So basically if you change the filter to is null good luck simply using the X 
on the filter bar to stop filtering.

What version of Sequel Pro are you using? What version of MySQL are you
connecting to on the server? Nightly build 3386, Mysql 5.0.92

Please provide any additional information below.
I think this is not intuitive and in the spirit of letting the user not shoot 
themselves ion the foot, and if they do at least make it easy for them to undo 
their action this should be reconsidered.

Original issue reported on code.google.com by possibil...@gmail.com on 15 Aug 2011 at 11:10

GoogleCodeExporter commented 9 years ago
So, to summarize:
Your issue is that the "IS NULL" filter has to be reset by switching back to 
the "=" filter?

Original comment by schlabbe...@gmail.com on 21 Aug 2011 at 6:13

GoogleCodeExporter commented 9 years ago
I expect the following:

- No inappropriate navigation buttons - I should not be able to navigate 
somewhere that is obviously incompatible with the MYSQL table definitions

- If I choose ANY FILTER I should always have an X button active to get rid of 
the filter. 

Original comment by possibil...@gmail.com on 25 Aug 2011 at 10:44

GoogleCodeExporter commented 9 years ago
Issue 1161 has been merged into this issue.

Original comment by schlabbe...@gmail.com on 26 Aug 2011 at 9:15

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
The bugreport states: 
"3. Observe empty content table with filter set to IS null and no easy way to 
remove filter"

What would be the non-easy way to remove the filter? I have an active "IS NULL" 
filter on all tables and it's encredibly annoying... but I can't find a way to 
remove it.

Original comment by ra...@future500.nl on 7 Aug 2012 at 10:27

GoogleCodeExporter commented 9 years ago
That is annoying, sorry...

If for each table you change the operator from "IS NULL" to "is" or "=", that 
should stick.  The problem is that IS NULL is a valid filter for all fields, 
and will therefore transfer across on changed selections if there's no filter 
saved for the other table already...

Original comment by rowanb@gmail.com on 7 Aug 2012 at 11:33

GoogleCodeExporter commented 9 years ago
No that's just the point - it does not stick. Here's what I have tested sofar:

In any table I select the filter is "IS NULL"; 
if I change it to "=" and click filter, I get the table contents without 
filter; 
If I click on a different table and then back to the original table, the filter 
is "IS NULL" again.

If I add a filter, say "= 1", I get filtered results;
If I click on a different table and then back to the original table, the filter 
is still "= 1" (as expected).
If I remove the filter with the x I get the table contents without filter;
If I click on a different table and then back to the original table, the filter 
is "IS NULL" again.

Original comment by ra...@future500.nl on 7 Aug 2012 at 11:53

GoogleCodeExporter commented 9 years ago
If you click on the different table, is that one *also* set to "IS NULL"?  That 
seems to be the problem here - it's a bit viral.  Setting *both* to "=" should 
stick.

Original comment by rowanb@gmail.com on 7 Aug 2012 at 12:21

GoogleCodeExporter commented 9 years ago
Ah that explains a lot, including the "no EASY way" comment.

I have reset *all* the table filters and finally killed my viral runaway IS 
NULL filter... thanks!

Original comment by ra...@future500.nl on 7 Aug 2012 at 12:31

GoogleCodeExporter commented 9 years ago
This should be Type-Defect, Priority-Medium in my opinion. The "viral" nature 
of the IS NULL filter means that half of my hundreds of tables ended up with 
"IS NULL" filters, confusing me as to why my tables were empty. Then I had to 
Google this issue, and manually go through each table to fix it. Not a small 
problem in my mind.

Original comment by ben.cl...@gmail.com on 13 Apr 2015 at 6:09