vieten / sequel-pro

Automatically exported from code.google.com/p/sequel-pro
Other
0 stars 0 forks source link

Error highlighter doesn't highlight line specified in error message. #1186

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When creating a table with a syntax error, the highlighter incorrectly 
highlighted line 3 when the error message specified the error was on line 10.

In the screenshot, you can see that the error lies with the trailing comma on 
line 9, so the paren on line 10 produces the error.  However, the paren on line 
3 is the one highlighted.

Original issue reported on code.google.com by pnomo...@gmail.com on 12 Sep 2011 at 7:21

Attachments:

GoogleCodeExporter commented 9 years ago
Hi there,

The only information we get back about the error is the message you see 
displayed below (and the error number, but that's less useful!); we then 
attempt to match that in the string.  As you've seen, this can be inaccurate 
for every short error "near" messages.

Perhaps it'd be better not to show the position if there's multiple 
occurrences, to reduce confusion, instead selecting the entire string.  Would 
you prefer that?

Original comment by rowanb@gmail.com on 12 Sep 2011 at 8:58

GoogleCodeExporter commented 9 years ago

Original comment by schlabbe...@gmail.com on 12 Sep 2011 at 8:58

GoogleCodeExporter commented 9 years ago
Of course there is the line number!  Not sure how I missed that, we should be 
able to parse that out as well; further updates will occur on #1152.

Original comment by rowanb@gmail.com on 12 Sep 2011 at 9:05