search

vieten / sequel-pro

Automatically exported from code.google.com/p/sequel-pro
Other
0 stars 0 forks source link

Security: 'Save Connection' divulges query history without warning #1228

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The 'File' - 'Save Connection' command saves the connection information to a 
file in XML format, and by default includes query history as 'queryHistory'.  
The query history includes queries run against the current connection _and 
other, previous connections_.  I think that's because of the way users create 
connections, but I still think it's an issue because the exporting of query 
history isn't disclosed to the user, nor is it an optional item.

If it works the way I think it does... because Sequel Pro has the 'add' button 
in 'Preferences' and not directly on the 'New Connection' screen, the default 
user behavior is to overwrite another connection's credentials and addresses 
with the new connection's information and either add the new connection to 
favorites or just directly click 'Connect' if it's a one-time connection.

The problem here is that the query history of the previous connection is now 
dragged along to the new connection, and could be exported.

I'll include in a separate feature request to add a simple '+' button to create 
a blank connection, but I think query history should NOT be included in a saved 
connection, at least by default.  By not knowing this information was exported 
out, I sent off to a client a file that contains lots of queries on other 
projects... but the only wording around the 'Save Connection' feature is that 
it saves the connection (credentials and access hosts), nothing else.

Sequel Pro 0.9.9.1, Build 3408.

Original issue reported on code.google.com by tonywebster on 11 Nov 2011 at 8:14

GoogleCodeExporter commented 9 years ago 
This is worse than I thought.  I was wrong about the fact that this happens 
when you duplicate a connection -- query history is GLOBAL and queries made 
anywhere in the application get exported anytime you save a connection.  This 
is a really big deal and a big security risk!

Original comment by tonywebster on 18 Nov 2011 at 5:55

GoogleCodeExporter commented 9 years ago

Original comment by stuart02 on 24 Oct 2013 at 7:43