[patch] Compilation error due to untyped delegate in SPTextViewAdditions

[GoogleCodeExporter]

Solved with SPCustomQuery *customQuery = [self delegate];

Original issue reported on code.google.com by pornel...@gmail.com on 28 Dec 2011 at 8:49

Attachments:

• currentQueryRangeDelegate.diff

[GoogleCodeExporter]

Original comment by stuart02 on 2 Jan 2012 at 4:02

• Changed state: NeedsReviewed
• Added labels: Component-Logic, Milestone-Release0.9, Priority-Medium, Type-Defect, Usability

[GoogleCodeExporter]

Thanks for the report - I assume this is in something with different 
compilation settings than Sequel Pro, or have you successfully moved to Xcode 4 
without breaking the nibs?

I applied the patch in a slightly different way in r3453; for the record, are 
you happy with Sequel Pro moving to BSD or MIT instead of GPL in the future?

Original comment by rowanb@gmail.com on 4 Jan 2012 at 11:22

• Changed state: AwaitingFeedback

[GoogleCodeExporter]

Yes, that's for Xcode 4. I managed to compile it with only half-broken nibs :)

The cast works as well.

Usually I wouldn't mind a BSD-style license, but I'm worried that tightly 
controlled Apple App Store might become the only place where OS X users can or 
will get software from. To prevent that I believe there needs to be high 
quality software existing only outside the walled garden, so I prefer Sequel 
Pro to remain GPL.

Original comment by pornel...@gmail.com on 6 Jan 2012 at 9:57

[GoogleCodeExporter]

Hi pornelski,

While I respect that view, I'm afraid we are working towards a license change - 
not to exist solely within the walled garden, but so that we can at least visit 
it.  (There's also the big advantage of allowing many more developers to use 
the code we've written.)

So I've rolled the patch out again in r3463.  (We'll address the issue anew in 
due course when we move to Xcode 4 ourselves - which will likely happen in a 
few weeks; there's a new framework incoming first, then a splitview class to 
sort out our nib issues… so it'll all get addressed soon)

Original comment by rowanb@gmail.com on 10 Jan 2012 at 11:25

• Changed state: WontFix