search

vieten / sequel-pro

Automatically exported from code.google.com/p/sequel-pro
Other
0 stars 0 forks source link

[REQ] Add preference to (not) add backticks around keywords #764

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I'd like to turn on and off the quotes for table atribute names in preferences 
dialog.

Best Regards

Original issue reported on code.google.com by roberto....@gmail.com on 20 Jul 2010 at 11:38

GoogleCodeExporter commented 9 years ago 
Hi Roberto,

Could you give us a little more background on this issue, and why you want it?

Original comment by rowanb@gmail.com on 20 Jul 2010 at 11:51

GoogleCodeExporter commented 9 years ago 
Hi, 

I came from EMS SQL Manager for MySQL for Windows this soft has the option to 
quote identifiers or not and I don't like to quote the table and column names 
in queries, this is not necesary in most of the cases.

I think that is more clear to write queries without quotes.

Best Regards

Original comment by roberto....@gmail.com on 20 Jul 2010 at 11:59

GoogleCodeExporter commented 9 years ago 
I'm not sure I understand correctly what you mean. Do you dislike the backticks 
that are added when using the autocomplete feature in the custom query view?

That is, if you type:
select id, name, descr<ESC>
Sequel Pro completes this as:
select id, name, `description`

If this is what you mean -- I'm with you. I also dislike this....

However, the identifiers are quoted for a reason. Some people use spaces or 
reserved words in field names. These reserved keywords vary between different 
versions of mysql. To further complicate the issue, some keywords don't have to 
be quoted when used as identifiers (eg. you can name a field TEXT and you don't 
have to quote it, even though TEXT is a keyword)

I don't like the idea of adding a preference for that. The preference window is 
already cluttered enough. Which only leaves the option of a smart quoting 
algorithm.

Let's assume we come up with a very reliable smart quoting algorithm that only 
quotes identifiers when necessary. Even then the current method has the 
advantage that it's very predictable. People might wonder why some identifiers 
are quoted and others are not.

While I personally also favor a smart quote algorithm, I think we still have to 
discuss this issue a bit.

Original comment by jabakobob@gmail.com on 20 Jul 2010 at 6:46

GoogleCodeExporter commented 9 years ago 
Exactly it's the same thing that you're describing, I dislike that backticks, I 
know the reasons for reserved keywords and spaces but un the 99% of the cases 
they don't need the backticks.

Will be great if the quoting algorithm could be inteligent and only quotes the 
necesary column names and not all of them.

I'm agree with you.

Best Regards.

Original comment by roberto....@gmail.com on 20 Jul 2010 at 7:59

GoogleCodeExporter commented 9 years ago

Original comment by schlabbe...@gmail.com on 19 Sep 2010 at 8:28

GoogleCodeExporter commented 9 years ago 
I actually find myself bringing up auto-complete to verify my half-written 
column name is the correct one, and then cancelling out of it to type the 
column name in manually. Simply because I don't want ugly backticks around my 
SQL unless they are actually needed.

Original comment by abhibeck...@gmail.com on 5 Aug 2011 at 2:02

GoogleCodeExporter commented 9 years ago 
I would also appreciate an option to turn this off; my company has quite strict 
policies about field and table names (underscores, no spaces, and no reserved 
words), so the backticks become unnecessary and I always just end up 
find-replacing them all away after I'm done anyway.

Original comment by scottast...@gmail.com on 23 Sep 2011 at 11:29

GoogleCodeExporter commented 9 years ago 
Another vote to add this option. If you feel the preferences pane is getting 
cluttered, how about an additional "Advanced" tab to put "pro" settings such as 
this in there.

Original comment by cnor...@enphaseenergy.com on 12 Jul 2012 at 8:30

GoogleCodeExporter commented 9 years ago 
Optionally, let ESC trigger the current method, and cmd-. trigger the method 
without backticks (or vice-versa).  I don't even see cmd-. listed as a 
shortcut, but it seems to do the save as ESC in 0.9.9.1.

Original comment by cnor...@enphaseenergy.com on 12 Jul 2012 at 8:35

GoogleCodeExporter commented 9 years ago 
Just a hit for people who suffer from these backticks on autocomplete.
CMD+Z removes backticks right after the autocompletion (but preserves 
autocomplete result!).
Press once more to revert to the state before autocomplete.

Original comment by ysol...@gmail.com on 28 Aug 2012 at 12:51

GoogleCodeExporter commented 9 years ago 
Backticks are only useful for people with badly designed table and column 
names. So forcing backticks and polluting our clean SQL, for a minority of poor 
database instances out there is really frustrating. Please make this a 
preference to turn it off. I'll throw in a donation if you do :)

Original comment by mrangryf...@gmail.com on 5 Jun 2013 at 1:04

GoogleCodeExporter commented 9 years ago 

By convention and coding standards none of the tables or fields in our 
databases use any spaces in the identifiers which require backtick delimiters 
in SQL statements.  Backticks as delimiters is a MySQL only syntax.  Backticks 
are only required when there are spaces in the identifiers.  We would prefer to 
keep our syntax more open to other database standards. So we don't use 
Backticks in any of our SQL.

Could you add an option in the preferences to disable using backticks ` when 
prefilling identifiers ? 

Right now, we have to edit out the backticks which eliminates the usefulness of 
prefill. Prefill saves a few keystrokes but adds many more to delete the 
backticks.  If we had an option to turn off the backticks on all prefill then 
SequalPro would be much, much more useful to us. 

Instead of:
 select `subscribers_active` from `subscribers`
we would like a preference option that would allow the prefill of fieldnames 
and tables to not have backticks:
select subscribers_active from subscribers

By the way - I must say you have produced a really excellent, top quality user 
interface editor.  
Thanks for your consideration. 
David

Original comment by beyonden...@gmail.com on 10 Jun 2013 at 12:36

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I'll add another polite request for a backtick-less autocomplete option.

Original comment by psych...@gmail.com on 1 Jul 2013 at 4:20

GoogleCodeExporter commented 9 years ago 
Same - please add a preference which allows backquotes in autocompletion to be 
disabled. If you're worried about cluttering the preference screen, have a look 
at the IntelliJ Idea preference dialog ;-)

Original comment by ridder....@gmail.com on 4 Jul 2013 at 2:39

GoogleCodeExporter commented 9 years ago 
+1 to add a preference to avoid backtick

Original comment by mry.shar...@gmail.com on 9 Aug 2013 at 8:36

GoogleCodeExporter commented 9 years ago 
+1 to add a preference to avoid backtick

Original comment by dharamgo...@gmail.com on 13 Aug 2013 at 4:56

GoogleCodeExporter commented 9 years ago 
My vote for this feature too, if it counts.  Backticks are generally not needed 
(unless you use reserved keywords and names with spaces) and its use makes the 
syntax cluttered and less readable.  So an option to not use them in exports, 
'create table' statements etc. would be very useful.

Original comment by greddy@momentsocial.com on 17 Sep 2013 at 1:19

GoogleCodeExporter commented 9 years ago 
+1 to add a preference to avoid backtick

Original comment by p...@redgalaxy.co.uk on 8 Jan 2014 at 9:35

GoogleCodeExporter commented 9 years ago 
+1 - I think the crowd has spoken.

Original comment by fogle...@gmail.com on 3 Feb 2014 at 6:11

GoogleCodeExporter commented 9 years ago 
It seems the band went home hours ago, though. :\

Original comment by cnor...@enphaseenergy.com on 3 Feb 2014 at 6:51

GoogleCodeExporter commented 9 years ago 
No, the band moved to https://github.com/sequelpro/sequelpro/issues/764 :) 
Still not playing, though :-/

Original comment by haavard.pedersen on 18 Mar 2014 at 10:20

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
+1

I'm glad I'm not alone here. Rather than a preference to remove them it would 
sure be better to only use them when necessary. Which in my experience would be 
never.

Original comment by runloop...@gmail.com on 12 Feb 2015 at 9:30

GoogleCodeExporter commented 9 years ago 
+1 - I'm agree to add on/off back quote to preference

Original comment by sunti...@gmail.com on 14 Feb 2015 at 11:38

GoogleCodeExporter commented 9 years ago 
+1. Total agreement. I like the advance/pro preferences idea as well. I've 
never felt overwhelmed with options in the preferences section.

Original comment by jayspeng...@side.cr on 13 Mar 2015 at 7:53

GoogleCodeExporter commented 9 years ago 
Just another +1 for this feature request. The SQL is really cluttered and hard 
to read with all the backticks. I can easily add them if needed, but 99% of the 
time, they are not.

Original comment by j.yz...@gmail.com on 26 Apr 2015 at 9:12

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
+1 for option to disable backticks.

Anyone just coming across this, #10 above mentioned cmd-Z: This does do it (I 
found my behavior just opposite that cmd-z twice would remove the backticks) 
but sure is cumbersome.  And then they still want to come back again -- aack :)

Original comment by bronius....@praxent.com on 5 May 2015 at 2:26

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
err.  I have come back to this thread a number of times and can't seem to get 
cmd-Z to undo just the backticks anymore.
OOh, will I really be the last commenter on this project before Google Code 
goes stale?  Great way to immortalize me-- a curmudgeon in infamy.

Original comment by bronius....@praxent.com on 6 Aug 2015 at 4:03

GoogleCodeExporter commented 9 years ago 
another vote for disabling this: `

Original comment by mgr...@workmarket.com on 12 Aug 2015 at 5:10

GoogleCodeExporter commented 9 years ago 
I would also like to be able to NOT add the back ticks. They are an annoyance 
99% of the time.

Original comment by jon.pe...@responsetap.com on 21 Aug 2015 at 4:03