add & to CHECK_THROW_AS to resolve warnings

vietjtnguyen / argagg

A simple C++11 command line argument parser

MIT License

224 stars 28 forks source link

add & to CHECK_THROW_AS to resolve warnings #25

Closed rianquinn closed 4 years ago

rianquinn commented 4 years ago

With the latest GCC, I was getting a lot of compile warnings with the tests as they are missing & on the catch statement and exceptions should not be caught by value.

vietjtnguyen commented 4 years ago

Nice catch. Could you go ahead and change them to const reference then?

rianquinn commented 4 years ago

yeah, that should be easy enough.