assignment-1

[vietvodoi123]

https://df-frontend-2023-theta.vercel.app/

[chinhld12]

Hi @vietvodoi123 ,

Below is the review for your first assignment.

Requirements

• [x] Render correct table elements
• [x] Create book
• [x] Delete book
• [x] Search book by title
• [ ] Semantic HTML
• [x] Standard use of CSS and JavaScript
• [x] Store data in LocalStorage

Final result: ✅ passed 70% of requirements

Feedback:

1. Should retain the current filtered list with search keywords after adding or removing a record.

   

2. We should add additional font combinations to the font-family in CSS to enhance resilient web typography.

3. Should use try/catch for handling parse JSON in case the item has bad JSON data. Read more

4. Can use Event Delegation to handle delete action for the whole table instead of adding an event with for loop directly to elements

5. The Delete button should be used with the correct button element

6. Search functionality should operate in a case-sensitive manner; presently, it does not recognize uppercase search input on the web.

7. Should be used with meaningful variables, for example: isValidatedName, and isValidatedAuthor instead of ok, and ok1, please avoid ambiguous names/abbreviations.