assignment-2 - Githubissues

vietvodoi123 / df-frontend-2023

https://df-frontend-2023-delta.vercel.app

0 stars 0 forks source link

assignment-2 #2

Open vietvodoi123 opened 1 year ago

vietvodoi123 commented 1 year ago

https://df-frontend-2023-2tkr.vercel.app/

ngolapnguyen commented 1 year ago

Good work 👍

Requirements

[x] Render book list with pagination
[x] Create book
[x] Delete book
[x] Search book by title
[x] Standard use of React component & state
[x] Light/dark mode

Final result: ✅ passed 70% of requirements

Feedbacks

Good implementation of dark-theme with CSS variables 👍

Everything is decent so I have no particular feedbacks. Some minor suggestions:

We can also move the pagination logic to BookContext to make App.js even cleaner
As a good practive, Backdrop should be a part of modal components instead of being rendered separately. It'll help simplify the rendering logic
...