search

viewizard / astromenace

Hardcore 3D space scroll-shooter with spaceship upgrade possibilities.
https://viewizard.com
Other
221 stars 30 forks source link

Remove unneeded dependency on X11 #12

Closed AMDmi3 closed 5 years ago

AMDmi3 commented 5 years ago

At least on FreeBSD, this is not needed.

Even if it's needed on Linux, it's used incorrectly, as X11_LIBRARIES would link with libX11 + any other X11 libs it can find (e.g. libXext, libSM, libICE, etc.). This hinders reproducible builds, creates needless dependencies and slows down app startup.

This change must be tested on Linux, and if it turns out to break the build, it could be redone with explicit list of X libs (e.g. ${X11_X11_LIB} instead of ${X11_LIBRARIES})

viewizard commented 5 years ago

Yes, we dont need this one any more, all related code was removed from the game, since SDL2 have all we need now.