search

viewstools / yarn-workspaces-cra-crna

How to use yarn workspaces with Create React App and Create React Native App (Expo) to share common code across
151 stars 23 forks source link

Fix windows paths #11

Closed nick-michael closed 6 years ago

nick-michael commented 6 years ago

The paths returned from getWorkspaces are not platform agnostic, and break when running on windows builds. path.join will return correct platform agnostic paths, but these get corrupted by glob.sync. 'D:\\Users\\nickm\\Documents\\Code\\my-app\\core'

becomes

'D:/Users/nickm/Documents/Code/my-app/core'

Happy to move this fix across into the 'get-yarn-workspaces' package if it is preferred.

Fixes #13

dariocravero commented 6 years ago

Thanks! Sorry for the delay in merging it. It's released as v1.0.3 :)