search

viezel / NappDrawer

A side drawer navigation container view controller for Appcelerator Titanium.
MIT License
247 stars 128 forks source link

Swap out android drawer for DrawerLayout #113

Open mattapperson opened 10 years ago

mattapperson commented 10 years ago

I think it would be great if we considered moving the Android Drawer to use the native android DrawerLayout rather then a 3rd party library.

thoughts?

viezel commented 10 years ago

yes very.. it seems much more solid. I just dont have the time.

mattapperson commented 10 years ago

ill get that done then (can you tell im working on a project that needs a drawer)

viezel commented 10 years ago

Haha :) there is nothing like client motivation.

viezel commented 10 years ago

Check out https://github.com/Tripvi/Ti.DrawerLayout If we could get that in and use the API as the iOS version.. Then it's perfect.

manumaticx commented 10 years ago

I've just had a look at this as @mattapperson pointed me here on twitter.

I'm afraid that this change would disable most of the existing API. With the native drawer layout you would have to drop:

These things can't be accomplished with the DrawerLayout (or at least I don't know how it could be done).

Maybe it would be possible to create a custom DrawerLayout using the native SlidingPaneLayout to keep existing functionality but it would imply a lot of work.