search

viezel / NappDrawer

A side drawer navigation container view controller for Appcelerator Titanium.
MIT License
248 stars 128 forks source link

Not working with SDK 6.0.0 #199

Closed PietroGranati closed 6 years ago

PietroGranati commented 7 years ago

As titanium guidelines the module must be recompiled with minimum SDK

Colemack commented 7 years ago

+1

macCesar commented 7 years ago

+1

Max87ZA commented 7 years ago

Can somebody please compile it with new SDK? Thanks

MarkBoyer commented 7 years ago

I have done a simple recompile, I have done VERY minimal testing, there is no warrantee given or implied, but if you would like to download this version and TEST IT HEAVILY, feel free...

https://github.com/MarkBoyer/Appcelerator-Modules

I am by no means attempting to take any credit, and I am by no means a Java developer, but like many, I rely HEAVILY on this module in my Appcelerator development.

hopstad commented 7 years ago

MarkBoyer : Thanks for your fix, but Im affraid it crashed my app. It works by dragging, but opening from a toggleLeftWindow() crashed it.

MarkBoyer commented 7 years ago

@hopstad - Is it possible there's something else going on with the crash? I only ask because I went back and tested again using the Genymotion simulator and it works with Android 5.1.0 and 6.0.0 for me using both the swipe and toggleLeftWindow. I do use Fokke's widget interface but that shouldn't make a difference.

hopstad commented 7 years ago

@MarkBoyer I have a rather large and complex app so it might be something else causing it. But it's weird because it's working fine with the old version.

I'll look more into it tomorrow. Thanks

EDIT: After looking more into this its seems to be related to the android back button which does something different than before in 6.0.0 ? It seems to handle differently. So its now closing the application instead of performing toggleLeftWindow() which it did before. So the problem seems lie with my app like you said.

EDIT2 : Confirmed fixed by using win.onBack() for handling the androidback button instead of the eventlistener I used earlier.

So my problem was not related to MarkBoyer's fix at all. Sorry for the trouble Mark.