search

viezel / NappDrawer

A side drawer navigation container view controller for Appcelerator Titanium.
MIT License
247 stars 128 forks source link

Update Android for Titanium SDK 6.2.0+ #203

Closed sgtcoolguy closed 7 years ago

sgtcoolguy commented 7 years ago
viezel commented 7 years ago

I dont understand. Why update the min requirements if there is no new code? I mean, which benefits am I missing here?

sgtcoolguy commented 7 years ago

Titanium SDK 6.2.0+ (which will likely actually become 7.0.0) has an updated V8 core we build on top of for Android. This update of V8 from 5.3 to 5.9 causes native Android modules to need to be rebuilt (since they broke their API, which causes native code touching their API to be broken unless rebuilt). So despite you not needing to touch native code in any way, the module still needs to be built against the updated V8 to work on it. This PR makes the minimal changes necessary to update the module to be rebuilt.

We include the minsdk and apiversion values in the manifest to allow the SDK to know the module compatibility (specifically, the apiversion is the value that gets bumped at the SDK level when we do an update of V8 that includes breaking API changes).

viezel commented 7 years ago

thanks for the information. I was not aware.