search

viezel / NappDrawer

A side drawer navigation container view controller for Appcelerator Titanium.
MIT License
248 stars 128 forks source link

fix issue with On-Screen navigation buttons eclipsing the lower porti… #204

Closed fahad86 closed 7 years ago

fahad86 commented 7 years ago

fix issue with On-Screen navigation buttons eclipsing the lower portion of the drawer when app installed with Ti SDK 6.1.0+

https://jira.appcelerator.org/browse/AC-5036

credits: Yordan Banev (Axway)

viezel commented 7 years ago

looks great, but we just merged this: https://github.com/viezel/NappDrawer/pull/203 we cannot both have min 6.2.0 and 6.1.0 as minimum sdk.

@sgtcoolguy care to comment?

fahad86 commented 7 years ago

thanks @viezel I've amended the my last commit (hence PR) to leave the min SDK and API values as is. The module was however compiled with 6.1.1.GA

fahad86 commented 7 years ago

merge?

viezel commented 7 years ago

Thanks