search

viezel / NappUI

A collection of extended functionality for the UI components of Titanium SDK
Other
121 stars 34 forks source link

Custom header support breaks iframes #57

Open milgner opened 9 years ago

milgner commented 9 years ago

Commit 3633dbd broke handling of iframes. I'm not sure whether it's in remote content only, but assume it's not.

It would first navigate to 'about:blank' and then to the URL of the iframe, showing only that one. Reverting the commit fixed the problem for us. See 0b36673832e56b6eeed06f4edaab3588406b13d3.

Encountering an iframe will also trigger shouldStartLoadWithRequest in the webview delegate and I guess that this line then causes the problem. But since I have zero experience with iOS development and only passing familiarity with Objective C I'd like to leave finding a fix for this to someone who actually knows what they're doing :smirk:

milgner commented 9 years ago

Edit: I was right the first time, just accidentally grabbed a device with a wrong build in the meantime.

Looks like my optimism was a bit premature... The problem still occurs even after reverting the commit. I'll investigate a bit further, trying to remove the custom shouldStartLoadWithRequest altogether.