vifm / vifm.vim

Vim plugin that allows use of vifm as a file picker
333 stars 19 forks source link

Fix split/netrw window close handling #26

Closed rbong closed 5 years ago

rbong commented 5 years ago

There were window closing handling errors introduced with #22.

When opening netrw the folder buffer is deleted just before opening neovim. This prevents vifm from being reopened when exiting, but as an unintended side-effect it closes the current window. This has been fixed.

When exiting from a non-split window, the current buffer is deleted and the window is closed. Now, the window is closed only if vifm was opened in a split, the window is closed.

This fixes #25

rbong commented 5 years ago

I'm not sure why changes that have already been merged are showing in the diff. I will clean up my history and that should fix it.

rbong commented 5 years ago

Fixed the weird diff issues, should now be ready to merge if you're happy with it

rbong commented 5 years ago

I realized that this and some other changes break switching back to the alternate buffer. I've changed it so that when closing Vifm it will return to the original buffer if appropriate.

rbong commented 5 years ago

It's clear I need to really carefully test this. I have a resolution I believe. It was a careful mix of all of my previous tweaks.

I've performed all of the following tests. If there was a mistake I fixed it and repeated all of the tests.

All of the following settings were tested:

For all of the settings, all of the following things were tested:

Additional tests:

All tests were repeated in vim and neovim.

I have also cleaned up my branch history.

Unrelated issues encountered:

xaizek commented 5 years ago

Great. Thanks a lot, @rbong!