vifm / vifm.vim

Vim plugin that allows use of vifm as a file picker
325 stars 18 forks source link

Fix error on returning to deleted file #76

Closed rbong closed 2 years ago

rbong commented 2 years ago

When returning to a deleted file, an error briefly flashes on the screen and a new file cannot be opened.

xaizek commented 2 years ago

Are you sure that new file can't be opened? I tried in Vim and neovim, they print an error, but then open the file (in neovim you need to press Enter to dismiss the message).

rbong commented 2 years ago

Yes, for me, the new file doesn't open and the window doesn't get cleaned up.

Minimal .vimrc:

call plug#begin('~/.vim/plugged')
    Plug 'vifm/vifm.vim'
    let g:vifm_embed_term = 1
    let g:vifm_embed_split = 1
    let g:vifm_embed_cwd = 1
    let g:vifm_replace_netrw = 1
    let g:loaded_netrwPlugin = 0
call plug#end()

Vim version: 8.2.3877

xaizek commented 2 years ago

Updated my Vim to 8.2.4106, but it behaves like before. Here's how I'm testing it:

(bash) echo test > file
(bash) vim file
(vim) :Vifm
(vifm) :goto file
(vifm) :rename new-file
(vifm) Enter
(vim) Displays notification message which disappears in 1 or 2 seconds.
(vim) :file
(vim) Prints "new-file"
rbong commented 2 years ago

Displays notification message which disappears in 1 or 2 seconds.

If you press anything when the notification appears, that's when this behavior happens. I must have always pressed enter or escape or something to dismiss the message.

Let me know what you think the behavior should be, but for me it is an inconvenience.

xaizek commented 2 years ago

I'm fine with the change, thanks. Just wanted to know why I couldn't reproduce the behaviour.