vigehi
commented
2 years ago Thanks for the feedback!
please help me with the nav bar if you can record a video explaining it please do
thank you Every believer has received grace gifts, so use them to serve one another as faithful stewards of the many-colored tapestry of God’s grace. 1 Peter 4:10
On Sat, Jul 2, 2022 at 12:03 AM Okoroji Victor Ebube < @.***> wrote:
@.**** requested changes on this pull request.
Hi @vigehi https://github.com/vigehi,
You have done a great job so far! 💪 👏 You still need to work on a few issues before moving on to the next project, but you're almost there! Top highlight 🎯
- The Pull Request is following the GitHub Flow ✅
- The PR title and description are professional and descriptive ✅
- The commit messages are meaningful ✅
- The README is well documented ✅
- Linters are working properly ✅
Required Changes ♻️
Check the comments under the review.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In README.md https://github.com/vigehi/new-Portfolio/pull/1#discussion_r912224841:
+
+## 🤝 Contributing
+Contributions, issues, and feature requests are welcome!
+
+Feel free to check the issues page.
+
+Show your support
+Give a ⭐️ if you like this project!
+
+## Acknowledgments
+Hat tip to anyone whose code was used
+Inspiration
+etc
+
+## 📝 License
+This project is MIT licensed.
- You have a good readme structure and kudos for following the Microverse template 👍 . The MIT license you added ought to be a link to the MIT file which is missing in your project. Please add the MIT file so it can be referenced through the MIT link you will create in your readme.
In README.md https://github.com/vigehi/new-Portfolio/pull/1#discussion_r912226216:
\ No newline at end of file
+
+## Project Name
+Hello Microverse
+Simple HTML CSS Portfolio project
[OPTIONAL]
- I think you should consider adding a more personalized detailed description of your portfolio project and its purpose. This will make your project look more professional and anyone accessing your repo will have a good understanding oof what your project is all about. Please look into it.
In index.html https://github.com/vigehi/new-Portfolio/pull/1#discussion_r912232883:
@@ -0,0 +1,48 @@
+<!DOCTYPE html>
+
+
Portfolio +
+
Edith Oga
- I think you should consider wrapping your title in an anchor tag tag instead of
tag because the idea is to make the title clickable and always link to the homepage which is a good user experience and also semantic(good for browser accessibility) 😄.
In index.html https://github.com/vigehi/new-Portfolio/pull/1#discussion_r912238913:
+<!DOCTYPE html>
+
+
Portfolio +
+
Edith Oga
- I would strongly recommend you wrap your hamburger menu in a
In index.html https://github.com/vigehi/new-Portfolio/pull/1#discussion_r912242420:
Portfolio +
+
Edith Oga
Edith Oga
Software Developer
- KIndly ensure that your sub-title ("Software Developer") is wrapped in a header tag hx (i.e h2-h6). This is particularly good to make your code semantic 😄 and also helps screen readers have a better interpretation of the content in the header(hx) tag😄 i.e
Software Developer
In CSS/style.css https://github.com/vigehi/new-Portfolio/pull/1#discussion_r912248700:
- padding: 0;
- color: #fff;
+}
+
+#paragraph {
- color: black;
+}
+
+.mobile-view {
margin: 8px 18px;
height: 48px;
display: flex;
align-items: center;
justify-content: space-between;
color: black;
+}
- KIndly ensure that your design matches the Figma design template https://www.figma.com/file/l7SqJ3ZfkAKih9sFxvWSR4/Microverse-Student-Project-1?node-id=48%3A2346 chosen 👍. It is good to have a good UI which is a good selling point to your users and potential employers and it's also a good user experience 😄
Figma Design Your Design [image: image] https://user-images.githubusercontent.com/63473584/176967414-29e47b96-6c46-4a66-bd44-4417afdceed7.png [image: image] https://user-images.githubusercontent.com/63473584/176967478-bb837be0-aa60-4a0d-8a05-9ebd819535c3.png
— Reply to this email directly, view it on GitHub https://github.com/vigehi/new-Portfolio/pull/1#pullrequestreview-1026609691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUASMZTCFGAICQ7MW4EEEYLVR5MJDANCNFSM52KTZSOQ . You are receiving this because you were mentioned.Message ID: @.***>
victorokoroji commented 2 years ago
- if you are referring to the hamburger being wrapped in a nav tag, this is what you are expected to do:
<nav> // hamburger image </nav>This is so because the hamburger will contain the menu items which you will add later on in your project This blog post will give you more insight. Kindly go through it.
hello ihave tried to fit the image it has refused what can I do Every believer has received grace gifts, so use them to serve one another as faithful stewards of the many-colored tapestry of God’s grace. 1 Peter 4:10
On Tue, Jul 5, 2022 at 10:02 PM Daniel Maina @.***> wrote:
@.**** requested changes on this pull request.
Hi @vigehi https://github.com/vigehi ,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there! Highlights
✔️ No linter errors ✔️ Github flow was correctly used Required Changes ♻️
Check the comments under the review. Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
_As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html https://github.com/vigehi/new-Portfolio/pull/1#discussion_r914114516:
- Kindly ensure only the hamburger menu is wrapped with the
In index.html https://github.com/vigehi/new-Portfolio/pull/1#discussion_r914119991:
Document +
+
+
- Kindly ensure the design of this section matches the Figma design given below is a comparison; Figma Design Your design [image: image] https://user-images.githubusercontent.com/61408860/177397320-49727629-006f-4143-946b-7ba14b69a159.png [image: image] https://user-images.githubusercontent.com/61408860/177397393-1e6f3215-94ec-4f12-b616-44b6f9e1599a.png
— Reply to this email directly, view it on GitHub https://github.com/vigehi/new-Portfolio/pull/1#pullrequestreview-1029082394, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUASMZS5SA2246SJ4N3ICA3VSSBFFANCNFSM52KTZSOQ . You are receiving this because you were mentioned.Message ID: @.***>
i have done this Every believer has received grace gifts, so use them to serve one another as faithful stewards of the many-colored tapestry of God’s grace. 1 Peter 4:10
On Wed, Jul 6, 2022 at 1:26 PM TufoinNkuo @.***> wrote:
@.**** requested changes on this pull request.
Hi @vigehi https://github.com/vigehi
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight ✅ You used the correct Github flow ✅ Descriptive pull request message ✅ linter error checks validated ✅ Documented your work professionally
Required Changes ♻️ Check the comments under the review
Optional suggestions _Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. https://airtable.com/shrQAqnBwek5a0O0s
In index.html https://github.com/vigehi/new-Portfolio/pull/1#discussion_r914676383:
@@ -0,0 +1,52 @@
+<!DOCTYPE html>
+
Document
- Great job so far. like the previous reviewer noted, kindly make your design look like the figma version. your hamburger icon is wrongly placed your version [image: Screenshot (211)_LI] https://user-images.githubusercontent.com/65298048/177529502-0f2669b2-19b8-4af6-a6a8-9d71e25d8477.jpg figma version [image: Screenshot (212)_LI] https://user-images.githubusercontent.com/65298048/177529533-1e3c561b-92c7-448e-b999-a503379ca416.jpg
In index.html https://github.com/vigehi/new-Portfolio/pull/1#discussion_r914677091:
Document I’m Mariane Glad to see you!
- [ optional] kindly add the font weight here to make it more like the figma and more recognizable.
— Reply to this email directly, view it on GitHub https://github.com/vigehi/new-Portfolio/pull/1#pullrequestreview-1029860480, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUASMZXPBCS4FGMYDAHNM4TVSVNMVANCNFSM52KTZSOQ . You are receiving this because you were mentioned.Message ID: @.***>
please run it again because i dont want to redo Every believer has received grace gifts, so use them to serve one another as faithful stewards of the many-colored tapestry of God’s grace. 1 Peter 4:10
On Wed, Jul 6, 2022 at 1:47 PM Edith Oga @.***> wrote:
i have done this Every believer has received grace gifts, so use them to serve one another as faithful stewards of the many-colored tapestry of God’s grace. 1 Peter 4:10
On Wed, Jul 6, 2022 at 1:26 PM TufoinNkuo @.***> wrote:
@.**** requested changes on this pull request.
Hi @vigehi https://github.com/vigehi
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight ✅ You used the correct Github flow ✅ Descriptive pull request message ✅ linter error checks validated ✅ Documented your work professionally
Required Changes ♻️ Check the comments under the review
Optional suggestions _Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. https://airtable.com/shrQAqnBwek5a0O0s
In index.html https://github.com/vigehi/new-Portfolio/pull/1#discussion_r914676383:
@@ -0,0 +1,52 @@
+<!DOCTYPE html>
+
Document
- Great job so far. like the previous reviewer noted, kindly make your design look like the figma version. your hamburger icon is wrongly placed your version [image: Screenshot (211)_LI] https://user-images.githubusercontent.com/65298048/177529502-0f2669b2-19b8-4af6-a6a8-9d71e25d8477.jpg figma version [image: Screenshot (212)_LI] https://user-images.githubusercontent.com/65298048/177529533-1e3c561b-92c7-448e-b999-a503379ca416.jpg
In index.html https://github.com/vigehi/new-Portfolio/pull/1#discussion_r914677091:
Document I’m Mariane Glad to see you!
- [ optional] kindly add the font weight here to make it more like the figma and more recognizable.
— Reply to this email directly, view it on GitHub https://github.com/vigehi/new-Portfolio/pull/1#pullrequestreview-1029860480, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUASMZXPBCS4FGMYDAHNM4TVSVNMVANCNFSM52KTZSOQ . You are receiving this because you were mentioned.Message ID: @.***>
Thanks for the feedback how can i merge? Every believer has received grace gifts, so use them to serve one another as faithful stewards of the many-colored tapestry of God’s grace. 1 Peter 4:10
On Thu, Jul 7, 2022 at 9:28 AM ismail courr @.***> wrote:
@.**** approved this pull request. Hi @vigehi https://github.com/vigehi,
Your project is complete! There is nothing else to say other than... it's time to merge it [image: :shipit:] Congratulations! 🎉
[image: cr-approve] https://user-images.githubusercontent.com/25227022/165483662-7b06c812-4cc0-40b9-a84c-4729d4cf10c3.gif Highlights
✔️ No linter errors ✔️ Used Github Flow ✔️ Work documented professionally Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
— Reply to this email directly, view it on GitHub https://github.com/vigehi/new-Portfolio/pull/1#pullrequestreview-1031047441, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUASMZWWAFVRX6ATXHVXDZDVSZ2IXANCNFSM52KTZSOQ . You are receiving this because you were mentioned.Message ID: @.***>
New pull request