vigetlabs / blendid

A delicious blend of gulp tasks combined into a configurable asset pipeline and static site builder
MIT License
4.97k stars 682 forks source link

watch task will not compile more than 48 html files #561

Open markjohnson4 opened 6 years ago

markjohnson4 commented 6 years ago

I just confirmed this to be the case with a fresh installation of blendid. This can easily be recreated by creating 50 copies of the index.html file (with different names), running "yarn run blendid", deleting production html files, and saving an html file in the "src/html" folder to trigger re-compiling the html. You'll see that only 48 files get compiled. No more.

kamilczujowski commented 5 years ago

Same Problem here, any idea?

olets commented 5 years ago

@markjohnson4 sorry for the slow response!!

I am not able to replicate to 50-file aspect of this.

I do however see a bug that might be what's going on for you: the html watch task appears to only notice changes to files that existed when you ran yarn run blendid.

If you re-save one of the original files (after creating a new one, with or without deleting two, and regardless of file count) does the new file show up in your destination directory?

olets commented 5 years ago

html task issue is now captured in #580. Thanks for calling our attention to it 👍

kasparsz commented 5 years ago

I managed to replicate on macOS, issue is related to gulp + browserSync https://github.com/BrowserSync/gulp-browser-sync/issues/79

In my case I had more than 48 html files, fix seems to be to comment out in html.js .pipe(browserSync.stream())

Downside of course is that browser doesn't reloads on html changes anymore, but at least more than 48 files can be created.

olets commented 5 years ago

@kasparsz thanks for finding that issue. The workaround might be to refactor Blendid and trigger the reload manually. Suppose we could also do something with gulp-count but that would add complexity.