search

vigetlabs / craft-viget-base

http://code.viget.com/craft-viget-base/
7 stars 3 forks source link

[#40] disable turbo to fix issues #41

Closed gregkohn closed 3 years ago

gregkohn commented 3 years ago

Sites using Turbo are not compatible with the current structure of the JS in the parts kit. While we could go down a route of configuration or detection to adjust how the parts kit is initialized (e.g. wrapping that in a listener for turbo:loaded), it seems to me that it's adding a bunch of code for little pay off. Disabling turbo is a quick and simple fix.

gregkohn commented 3 years ago

Also playing devil's advocate, is there any chance someone would want turbo in the parts kit?

Like, as a way of anticipating or diagnosing problems specific to Turbo?

davist11 commented 3 years ago

Well, at some point on the viget.com redesign I think there was some turbo load more stuff in the parts kit (which eventually got ripped out). And just mostly thinking should stuff like that ever live in the parts kit?

gregkohn commented 3 years ago

Gotcha. I don't think it's out of the question, but part of a larger discussion. For now, I think it's okay to fix the existing bug in the simplest way.