Closed davist11 closed 2 years ago
Looks good to me! Any risk of breaking changes? Or are most sites locking their version numbers here? Was just curious if switching to that controller would be non-functional with sites using craft-viget-base as a submodule.
So I tested this on a local craft install in a couple other scenarios:
So we will definitely add something to the changelog about removing the submodule initialization, and I think we bump the version to a major release.
Curious about Joshua's comment about delegated no longer being needed.
I'm not too worried about that. It doesn't break. Chris is supposed to own Docker now, so hopefully he can sort out the optimal setup.
we probs wanna release joshua's open PR as a minor change first
Agree
Instead of forcing everyone to add a
parts-kit/index.html
file that basically does nothing, automatically redirect to the first component like Storybook does.Also adjusted the docker setup so the vendor folder is available locally