search

vigetlabs / craft-viget-base

http://code.viget.com/craft-viget-base/
7 stars 3 forks source link

Redirect parts kit index request to first component #43

Closed davist11 closed 2 years ago

davist11 commented 2 years ago

Instead of forcing everyone to add a parts-kit/index.html file that basically does nothing, automatically redirect to the first component like Storybook does.

Also adjusted the docker setup so the vendor folder is available locally

davist11 commented 2 years ago

Looks good to me! Any risk of breaking changes? Or are most sites locking their version numbers here? Was just curious if switching to that controller would be non-functional with sites using craft-viget-base as a submodule.

So I tested this on a local craft install in a couple other scenarios:

  1. Bootstrapped both the base module and a sample module that initializes the base module as a submodule. The base module gets double initialized. The controller redirect works fine.
  2. Bootstrapped only my sample module that initializes the base module as a submodule. The controller redirect will not work and will throw a 404.

So we will definitely add something to the changelog about removing the submodule initialization, and I think we bump the version to a major release.

davist11 commented 2 years ago

Curious about Joshua's comment about delegated no longer being needed.

I'm not too worried about that. It doesn't break. Chris is supposed to own Docker now, so hopefully he can sort out the optimal setup.

we probs wanna release joshua's open PR as a minor change first

Agree