vigetlabs / craft-viget-base

http://code.viget.com/craft-viget-base/
7 stars 3 forks source link

[#66] Adds collections support in `Util::fillInEntries()` #67

Closed joshuapease closed 1 year ago

joshuapease commented 1 year ago

Util::fillInEntries() expects an array of entries. However, with Craft 4 going all in on Collections, it probably makes sense to support that type as well.

Context:

Ran into a lot of uses for this method on HRC's Craft 4 upgrade. Since eager loading returns collections, I figured it made more sense to just have our function embrace collections rather than change all uses of this function on HRC.

Curious y'alls thoughts