search

vigetlabs / gulp-rails-pipeline

Ditch the Rails Asset Pipeline and roll your own with Gulp
MIT License
646 stars 64 forks source link

Bump gulp-iconfont version #29

Closed rowanoulton closed 9 years ago

rowanoulton commented 9 years ago

If a version for the gulp-iconfont package is not specified, the iconfont task will fail to produce the sass needed for generated fonts. This is because the codepoints event has been replaced with glyphs in more recent distributions of gulp-iconfont. There are also a couple of slight adjustments to the way the unicode characters are retrieved which is detailed here.

Unless there's a particular reason to keep gulp-iconfont at v1, I propose we bump the package version and adjust the iconfont task as required.

PS: love the example project — just followed your lead in a project of mine and ran across the above, hope you find the patch useful.

greypants commented 9 years ago

ha! Just made this exact same change yesterday on gulp-starter, which is the base for this rails-flavored version. Great minds think alike :)

Thanks.