vigetlabs / gulp-rails-pipeline

Ditch the Rails Asset Pipeline and roll your own with Gulp
MIT License
646 stars 64 forks source link

Fails to build on heroku #36

Closed mtc2013 closed 8 years ago

mtc2013 commented 8 years ago

Error: Cannot find module 'gulp-watch' remote: at Function.Module._resolveFilename (module.js:338:15) remote: at Function.Module._load (module.js:280:25) remote: at Module.require (module.js:364:17) remote: at require (module.js:380:17) remote: at Object. (/tmp/build_310d1461a5bfcb66a7cd499838db21ac/gulp/tasks/watch.js:8:14) remote: at Module._compile (module.js:456:26) remote: at Object.Module._extensions..js (module.js:474:10) remote: at Module.load (module.js:356:32) remote: at Function.Module._load (module.js:312:12) remote: at Module.require (module.js:364:17)

It appears gulp-watch is required on in tasks/watch.js which is apparently being somehow run when heroku runs gulp build. I'm not sure how exactly as I am a gulp/nodejs newbie. But of course, gulp-watch is only a dev dependency and so not on heroku.

mikesmayer commented 8 years ago

I'm running into the same issue -- have you had any success solving this?

greypants commented 8 years ago

hm. I'll look into this... weird that this is just now popping up. We haven't changed anything here in quite some time.

chintanparikh commented 8 years ago

Hey all - just fixed this with npm install --save gulp-watch (and thus making it an actual dependency).

greypants commented 8 years ago

thanks @chintanparikh. Fixed.