vigetlabs / microcosm

Flux with actions at center stage. Write optimistic updates, cancel requests, and track changes with ease.
http://code.viget.com/microcosm/
MIT License
487 stars 29 forks source link

refactor images, change heading colors on scroll #464

Closed ccchwang closed 6 years ago

ccchwang commented 6 years ago

This PR worked on images and font colors:

ccchwang commented 6 years ago

@leobauza the CI website test is failing again but I think that's okay according to @nhunzaker?

nhunzaker commented 6 years ago

Pretty strange. Let's not worry about it. I wish I knew what was up tho :(

ccchwang commented 6 years ago

@nhunzaker yeah, it sometimes works and sometimes doesn't so I wonder if it's a CI thing? anyways, will keep moving

codecov-io commented 6 years ago

Codecov Report

Merging #464 into master will decrease coverage by 0.21%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   93.33%   93.11%   -0.22%     
==========================================
  Files          30       30              
  Lines        1065     1061       -4     
  Branches      199      201       +2     
==========================================
- Hits          994      988       -6     
  Misses         60       60              
- Partials       11       13       +2
Impacted Files Coverage Δ
packages/microcosm/src/domain-engine.js 80.88% <0%> (-17.65%) :arrow_down:
packages/microcosm/src/microcosm.js 93.39% <0%> (-5.67%) :arrow_down:
packages/microcosm/src/addons/action-form.js
packages/microcosm/src/addons/indexing.js 100% <0%> (ø)
packages/microcosm/src/history.js 77.27% <0%> (+0.75%) :arrow_up:
packages/microcosm/src/utils.js 95.89% <0%> (+1.36%) :arrow_up:
packages/microcosm/src/addons/action-button.js 100% <0%> (+3.12%) :arrow_up:
packages/microcosm/src/action.js 98.29% <0%> (+4.27%) :arrow_up:
packages/microcosm/src/key-path.js 85.71% <0%> (+7.14%) :arrow_up:
packages/microcosm/src/effect-engine.js 100% <0%> (+11.11%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 659a17d...b28f2f8. Read the comment docs.