Closed ccchwang closed 6 years ago
Merging #465 into ch/images-fontColor will increase coverage by
1.12%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## ch/images-fontColor #465 +/- ##
=======================================================
+ Coverage 93.8% 94.92% +1.12%
=======================================================
Files 29 30 +1
Lines 1033 1065 +32
Branches 195 199 +4
=======================================================
+ Hits 969 1011 +42
+ Misses 54 47 -7
+ Partials 10 7 -3
Impacted Files | Coverage Δ | |
---|---|---|
packages/microcosm/src/lifecycle.js | 66.66% <0%> (-33.34%) |
:arrow_down: |
packages/microcosm/src/key-path.js | 71.42% <0%> (-7.15%) |
:arrow_down: |
packages/microcosm/src/microcosm.js | 92.45% <0%> (-2.84%) |
:arrow_down: |
packages/microcosm/src/addons/action-button.js | 100% <0%> (ø) |
|
packages/microcosm/src/action.js | 98.29% <0%> (+3.41%) |
:arrow_up: |
packages/microcosm/src/history.js | 94.69% <0%> (+6.81%) |
:arrow_up: |
packages/microcosm/src/domain-engine.js | 86.76% <0%> (+7.35%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c4dfb2a...e1d1de0. Read the comment docs.
Question about images in general. Since this is so image heavy how are you handling preloading or lazy loading or anything like that?
@leobauza yes very good thought, I will think about and find a solution for that
ToggleContainer
into it's own React component