search

vigetlabs / microcosm

Flux with actions at center stage. Write optimistic updates, cancel requests, and track changes with ease.
http://code.viget.com/microcosm/
MIT License
487 stars 29 forks source link

lazy load images #469

Closed ccchwang closed 6 years ago

ccchwang commented 6 years ago

Added this lazysizes plugin and set some load styles.

ccchwang commented 6 years ago

@nhunzaker yarn deploy seems to work, but now it's failing because it can't find the react-lazysizes library I installed. I do see it in my node_modules so not sure why it can't find?

nhunzaker commented 6 years ago

Bummer. Looks like it might be a caching issue. I think the build caches based on the root package.json. This site is separate, so it might have gotten stuck.

I clicked "rebuild without cache". Let's see what happens. I'll also make a note to look at why this happened.

nhunzaker commented 6 years ago

Ahhh. I see now. react-lazysizes depends on lazysizes, which isn't getting pulled in for some reason. Hmmm.

codecov-io commented 6 years ago

Codecov Report

Merging #469 into master will decrease coverage by 1.35%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   97.18%   95.83%   -1.36%     
==========================================
  Files          31       29       -2     
  Lines        1103     1033      -70     
  Branches      204      195       -9     
==========================================
- Hits         1072      990      -82     
- Misses         27       37      +10     
- Partials        4        6       +2
Impacted Files Coverage Δ
packages/microcosm/src/history.js 87.12% <0%> (-7.58%) :arrow_down:
packages/microcosm/src/key-path.js 78.57% <0%> (-7.15%) :arrow_down:
packages/microcosm/src/domain-engine.js 97.05% <0%> (-2.95%) :arrow_down:
packages/microcosm/src/action.js 97.43% <0%> (-2.57%) :arrow_down:
packages/microcosm/src/microcosm.js 99.05% <0%> (ø) :arrow_up:
packages/microcosm/src/addons/indexing.js
packages/microcosm/src/addons/action-button.js
packages/microcosm/src/utils.js 98.63% <0%> (+1.36%) :arrow_up:
packages/microcosm/src/effect-engine.js 100% <0%> (+5.55%) :arrow_up:
packages/microcosm/src/addons/action-queue.js 100% <0%> (+6.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71f0bc6...1fbf86a. Read the comment docs.

ccchwang commented 6 years ago

@nhunzaker couldn't figure out why yarn was not installing that lazysizes dependency 😣 it wasn't a well-maintained package anyways so I used something else