Closed nhunzaker closed 6 years ago
Very cool!
Merging #521 into 12-stable will increase coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## 12-stable #521 +/- ##
=============================================
+ Coverage 99.78% 99.78% +<.01%
=============================================
Files 26 26
Lines 936 944 +8
=============================================
+ Hits 934 942 +8
Misses 2 2
Impacted Files | Coverage Δ | |
---|---|---|
src/addons/action-button.js | 100% <100%> (ø) |
:arrow_up: |
src/addons/action-form.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b5603fc...f6b8210. Read the comment docs.
What
This PR adds a
confirm
prop to ActionButton and ActionForm that allows users to bail out of action dispatch if the result is false. Like:Why
ActionButton doesn't have a great way to confirm actions like deleting a record. For symmetry, I also added this functionality to ActionForm.
Note: This is against 12.x, our stable release. I'll eventually move this over to 13.x too.