search

vigetlabs / react-ink

A React component for adding material design style ink
https://react-ink.netlify.com/
MIT License
324 stars 36 forks source link

Chrome 64: not working on mouse events #37

Open AnoXDD opened 6 years ago

AnoXDD commented 6 years ago

Been using this component for quite a while, until the ripple is not showing up on click when my Chrome is updated to 64. However, the ripple shows up if I touch my screen.

AnoXDD commented 6 years ago

Set hasTouch to be false seems to solve the issue (worked on both touch and mouse events from my laptop), although I don't know what Chrome 64 did to change the way ink detects the touch events.

nhunzaker commented 6 years ago

Gross. I'm guessing the touch detection is off.

nhunzaker commented 6 years ago

Ah... Actually. I bet the issue is that both touch and clicks are supported. We want to allow both.