search

vigetlabs / trackomatic

A high-performance tracking enhancement for Google Analytics.
Apache License 2.0
33 stars 4 forks source link

Identify browser support and make it consistent #15

Closed averyvery closed 8 years ago

averyvery commented 9 years ago

Some features work in legacy browsers, some don't. We should standardize on this and make sure that all features meet the same requirement.

averyvery commented 9 years ago

cc @solomonhawk

solomonhawk commented 9 years ago

I'm going to approach this with IE9 support in mind. If we want to we could create a separate trackomatic-legacy bundle that gets generated by the build for targeting IE8 support projects.

awavering commented 9 years ago

:+1:

averyvery commented 9 years ago

@solomonhawk in this case, does it make sense to just wrap the whole thing in...

if('querySelector' in document
     && 'localStorage' in window
     && 'addEventListener' in window) {
       ...
     }

...or just individual features?

solomonhawk commented 9 years ago

Yes we should just use that, good idea Doug.

solomonhawk commented 8 years ago

I implemented the mustard-cutting technique discussed here in 1.1.1.

awavering commented 8 years ago

Thanks @solomonhawk. Sounds like we're good to close this?

averyvery commented 8 years ago

Closing this.