search

vigetlabs / trackomatic

A high-performance tracking enhancement for Google Analytics.
Apache License 2.0
33 stars 4 forks source link

Refactor #22

Closed solomonhawk closed 9 years ago

solomonhawk commented 9 years ago

Modulez, build, architecture, buzz words.

Next TODO: Add tests.

I'm imagining a world in which we split up the trackomatic plugins into their own modules in order to make maintaining them easier which is part of the reason why I've opted to pass in the trackomatic instance to plugins who then access it's util methods, etc. as opposed to importing the util object into the plugin file itself.

If you have any sort of questions or thoughts at all please leave them here for discussion.

Thanks!

averyvery commented 9 years ago

I wish I had more time to review this today. If it's still open Friday, I'll look again.

averyvery commented 9 years ago

:+1:

solomonhawk commented 9 years ago

This work and feedback has been incorporated into https://github.com/vigetlabs/trackomatic/pull/25