search

vigetlabs / university

Community learning experiment
1 stars 4 forks source link

Assignment 1 #2

Closed averyvery closed 8 years ago

averyvery commented 8 years ago

Still trying to get this to run on Circle CI. Can't seem to run it on a specific branch, which seems odd, but maybe I'm missing something.

averyvery commented 8 years ago

:+1:

averyvery commented 8 years ago

:+1:

averyvery commented 8 years ago

I still need to add an .nvmrc to this. For some reason I found a really old convo where the nvm creators were saying nvmrc was a bad idea they would never do, but it turns out they ended up doing it.

nhunzaker commented 8 years ago

Super neat! I can't sufficiently express how happy I am to see proper source maps in Istanbul 1. :+1:

nhunzaker commented 8 years ago

Hey @averyvery: sorry for the trouble, but could you move this work to a folder under submissions, like:

root/
└── submissions/
    └── averyvery/

I've put a commit on master that adds the submission folder.

averyvery commented 8 years ago

Done. I'm guessing this'll break circleci for me, but i was mainly just doing it to learn how to run it.

nhunzaker commented 8 years ago

@averyvery Hmm. Yep... it will. You'll have to set up a custom test command.

We could set up Circle for this repo and do some fancy scripting to enumerate through the submissions, but that's kind of a bummer... hmm. I'll put more thought into this.

nhunzaker commented 8 years ago

@averyvery first submission. Congrats!