search

vigetlabs / uswds

fork of https://github.com/uswds/uswds
Other
1 stars 2 forks source link

don't automatically run `build` #1

Open olets opened 6 years ago

olets commented 6 years ago

install triggers build via spawn's postintall.

...
> spawn-sync@1.0.15 postinstall /Users/home/Sites/uswds-viget/node_modules/spawn-sync
> node postinstall

> node-sass@4.7.2 postinstall /Users/home/Sites/uswds-viget/node_modules/node-sass
> node scripts/build.js

Binary found at /Users/home/Sites/uswds-viget/node_modules/node-sass/vendor/darwin-x64-57/binding.node
Testing binary
Binary is fine

> axe-core@2.6.1 postinstall /Users/home/Sites/uswds-viget/node_modules/axe-core
> node build/utils/postinstall.js

> uswds@1.6.1 prepare /Users/home/Sites/uswds-viget
> gulp build
...

Is this is necessary for building the package in projects that include uswds as a dependency?

It means that npm link runs npm run build, which if not necessary means npm link is doing more than it needs to.

olets commented 6 years ago

TODO: get full npm i output. But it should be very much like:

Toggle to view full `npm link uswds` output ``` ➜ npm link npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/browser-sync as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/browser-sync npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/lt as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/localtunnel npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/shjs as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/shelljs npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/window-size as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/window-size npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/.bin/fractal as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/fractal npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/fractal/node_modules/.bin/browser-sync as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/fractal/node_modules/browser-sync npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/uuid as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/uuid npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/JSONStream as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/JSONStream npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/js-yaml as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/js-yaml npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/css-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/js-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/html-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/semver as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/semver npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/.bin/nopt as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/nopt npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/gulp/node_modules/.bin/semver as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/gulp/node_modules/semver npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/fsevents/node_modules/.bin/node-pre-gyp as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/fsevents/node_modules/node-pre-gyp npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/acorn-object-spread/node_modules/.bin/acorn as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/acorn-object-spread/node_modules/acorn npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/acorn-jsx/node_modules/.bin/acorn as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/acorn-jsx/node_modules/acorn npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/nunjucks/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/.bin/browser-sync as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/nunjucks/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/browser-sync npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/nunjucks/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/browser-sync/node_modules/.bin/lt as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/nunjucks/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/browser-sync/node_modules/localtunnel npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/.bin/fractal as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/.bin/browser-sync as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/browser-sync npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/browser-sync/node_modules/.bin/lt as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/browser-sync/node_modules/localtunnel npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/.bin/css-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/.bin/html-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/.bin/js-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/handlebars/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/.bin/fractal as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/.bin/css-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/.bin/html-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/.bin/js-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/.bin/html-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/.bin/js-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/.bin/css-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/.bin/css-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/.bin/html-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/js-beautify npm WARN rm not removing /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/.bin/js-beautify as it wasn't installed by /Users/home/Sites/uswds-viget/node_modules/@frctl/fractal/node_modules/@frctl/mandelbrot/node_modules/@frctl/fractal/node_modules/js-beautify > fsevents@1.1.3 install /Users/home/Sites/uswds-viget/node_modules/fsevents > node install [fsevents] Success: "/Users/home/Sites/uswds-viget/node_modules/fsevents/lib/binding/Release/node-v57-darwin-x64/fse.node" already installed Pass --update-binary to reinstall or --build-from-source to recompile > uws@9.14.0 install /Users/home/Sites/uswds-viget/node_modules/uws > node-gyp rebuild > build_log.txt 2>&1 || exit 0 > canvas-prebuilt@1.6.5-prerelease.1 install /Users/home/Sites/uswds-viget/node_modules/canvas-prebuilt > node-pre-gyp install [canvas-prebuilt] Success: "/Users/home/Sites/uswds-viget/node_modules/canvas-prebuilt/canvas/build/Release/canvas-prebuilt.node" is installed via remote > node-sass@4.7.2 install /Users/home/Sites/uswds-viget/node_modules/node-sass > node scripts/install.js Downloading binary from https://github.com/sass/node-sass/releases/download/v4.7.2/darwin-x64-57_binding.node Download complete ⸩ ⠋ : Binary saved to /Users/home/Sites/uswds-viget/node_modules/node-sass/vendor/darwin-x64-57/binding.node Caching binary to /Users/home/.npm/node-sass/4.7.2/darwin-x64-57_binding.node > spawn-sync@1.0.15 postinstall /Users/home/Sites/uswds-viget/node_modules/spawn-sync > node postinstall > node-sass@4.7.2 postinstall /Users/home/Sites/uswds-viget/node_modules/node-sass > node scripts/build.js Binary found at /Users/home/Sites/uswds-viget/node_modules/node-sass/vendor/darwin-x64-57/binding.node Testing binary Binary is fine > axe-core@2.6.1 postinstall /Users/home/Sites/uswds-viget/node_modules/axe-core > node build/utils/postinstall.js > uswds@1.6.1 prepare /Users/home/Sites/uswds-viget > gulp build [10:31:59] Using gulpfile ~/Sites/uswds-viget/gulpfile.js [10:31:59] Starting 'build'... [10:31:59] v1.6.1 U.S. Web Design System [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [10:31:59] build Creating distribution directories. [10:31:59] Starting 'clean-dist'... [10:31:59] clean-dist Removing distribution directories. [10:31:59] Finished 'clean-dist' after 397 ms [10:31:59] Starting 'docs'... [10:31:59] docs Copying documentation dist dir [10:31:59] Finished 'docs' after 143 ms [10:31:59] Starting 'copy-vendor-sass'... [10:31:59] copy-vendor-sass Compiling vendor CSS [10:31:59] Starting 'javascript'... [10:31:59] javascript Compiling JavaScript [10:32:00] Starting 'images'... [10:32:00] images Copying Images [10:32:00] Starting 'fonts'... [10:32:00] fonts Copying Fonts [10:32:05] Finished 'fonts' after 5.27 s [10:32:06] Finished 'javascript' after 6.53 s [10:32:06] Finished 'images' after 6.61 s [10:32:07] Finished 'copy-vendor-sass' after 7.86 s [10:32:07] Starting 'sass'... [10:32:07] sass Compiling Sass [10:32:09] Finished 'sass' after 1.71 s [10:32:09] Starting 'copy-dist-sass'... [10:32:09] copy-dist-sass Copying all SASS to dist dir [10:32:10] Finished 'copy-dist-sass' after 1.02 s [10:32:10] Finished 'build' after 11 s added 371 packages, removed 572 packages and updated 1212 packages in 163.277s /Users/home/.nvm/versions/node/v8.9.4/lib/node_modules/uswds -> /Users/home/Sites/uswds-viget ```