search

vigetlabs / washi

A simple, backbone inspired view helper.
http://vigetlabs.github.io/washi/docs/washi
MIT License
5 stars 2 forks source link

Illegal invocation if matches checks upon the document #16

Closed nhunzaker closed 9 years ago

nhunzaker commented 9 years ago

cc @cwmanning

screen shot 2015-01-05 at 8 09 37 am

nhunzaker commented 9 years ago

As best as I can tell, the real problem is here:

https://github.com/vigetlabs/washi/blob/master/src/delegate.js#L17

I can think of a couple of solutions. We could return false in matches.js if the element provided is not a DOM element, or we can check to make sure that there is a valid parent in delegate. Thoughts?

nhunzaker commented 9 years ago

Fixed