search

vigetlabs / wordpress-site-starter

2 stars 0 forks source link

[#102] Removing parent wp-block class from button css #109

Closed nathan-schmidt-viget closed 2 weeks ago

nathan-schmidt-viget commented 2 weeks ago

Summary

Bug I found when styling the buttons for IAFFF. The buttons styles correctly if they are in a pattern/component but not if they are just a button in the WP core Button group. Removing the parent classes fixes the problem.

Issues

Testing Instructions

  1. Add the button group to a page and make sure they are styled in the WP editor and the frontend.
  2. Make sure the buttons are styled in our blocks.

Screenshots

With parents classes on buttons css

Screenshot 2024-06-14 at 2 40 40 PM

With OUT parents classes on buttons css

Screenshot 2024-06-14 at 2 40 12 PM
bd-viget commented 2 weeks ago

I'm not even sure having the wp-block and/or acf-block is helpful, it was something that got pulled over from IAFF, so if we don't think they're useful identifiers, we can remove those from the ACF blocks.