search

vigetlabs / wordpress-site-starter

2 stars 0 forks source link

[#69] Page Header Component #79

Closed bd-viget closed 1 month ago

bd-viget commented 1 month ago

Summary

This PR adds the Page Header Component. The basic styles have been added with plain CSS, so it's going to need some of @nathan-schmidt-viget's Tailwind love!

Issues

Testing Instructions

  1. Create a new page
  2. Add the Page Header block

Screenshots

Screenshot 2024-05-20 at 5 11 52 PM Screenshot 2024-05-20 at 5 15 20 PM
bd-viget commented 1 month ago

I think this fulfills what the Figma images show but reading the ticket, I think there's a mismatch in spec versus images?

I thought so too, but I guess I assumed the Breadcrumbs were the "menu items" and the Company Logo was the image.

Also, it's usually a bit strange to specify the links in Breadcrumbs, usually the site map decides that automatically.

bd-viget commented 1 month ago

@ten1seven @stephaniefois

I think the description for ticket #69 was copied from ticket #67 and just not updated.

ten1seven commented 1 month ago

Yea, spec duplication seems to be the case.

bd-viget commented 1 month ago

Ok, when testing this, you may need to run composer install, WP Starter now includes RankMath, which is what we're using for breadcrumbs, but they need to be enabled.