vighnesh153 / simple-github-gist-api

[DEPRECATED: New package -> @vighnesh153/github-gist] Promise based abstraction, over http, for storing data on Github Gist.
MIT License
8 stars 2 forks source link

fix: linter and axios type bug #58

Closed gsgalloway closed 2 years ago

gsgalloway commented 2 years ago

This is the axios bug I ran into: https://github.com/vighnesh153/simple-github-gist-api/compare/master...gsgalloway:axios-bugfix?expand=1#diff-1f7b1dc25ba39718983fc93bec0ce58fae47500c0e71c6797ff307a9d2c8613bR110-R114

The axios response has a data property that needs to be accessed to get the gist contents

Then when trying to commit the fix I couldn't get the linter to pass. Added a bunch of typescript plugins for eslint to fix the linter errors I was getting. Along the way it auto-formatted the file

vighnesh153 commented 2 years ago

LGTM! Thanks for your contribution.