search

vigna / fastutil

fastutil extends the Java™ Collections Framework by providing type-specific maps, sets, lists and queues.
Apache License 2.0
1.78k stars 196 forks source link

Continue fixing previous bug #291

Closed goldfeder closed 1 year ago

goldfeder commented 1 year ago

I didn't correct all of the methods

vigna commented 1 year ago

OK, would it be too much to ask to check with unit tests the ImmutableSublist code? 🙈

goldfeder commented 1 year ago

Of course not, I should have done that. But I found a few more related bugs. Fixing all and will send with tests.

On Mon, Mar 13, 2023 at 1:22 PM Sebastiano Vigna @.***> wrote:

OK, would it be too much to ask to check with unit tests the ImmutableSublist code? 🙈

— Reply to this email directly, view it on GitHub https://github.com/vigna/fastutil/pull/291#issuecomment-1465964488, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZU7OPNNA67EABQWFLUBOTW337PHANCNFSM6AAAAAAVY5KGBE . You are receiving this because you authored the thread.Message ID: @.***>

goldfeder commented 1 year ago

Ok, please take a look now. I fixed a bunch of bugs in the sublist listiterator (now with tests) and also fixed one bug in the regular list iterator (back() checked the wrong value for remaining). Since there were no tests for the regular list iterator, I added them there too, even though I only fixed the bug in back().

vigna commented 1 year ago

Fantastic, thanks!