search

vignaesh01 / sfdx-package-generator

Salesforce Package.xml Generator Extension for VS Code
https://marketplace.visualstudio.com/items?itemName=VignaeshRamA.sfdx-package-xml-generator
Other
63 stars 31 forks source link

'Select All' works incorrectly when filtering #30

Open PotSeht opened 4 years ago

PotSeht commented 4 years ago

Hi Vignaesh, thanks for all the work you've done to bring people this extension, its extremely useful!

I just wanted to raise that if you when you filter a given set of records, then use the 'SELECT ALL' button, rather than just selecting the set of filtered records, it selects all records against the metadata type. This populates the package.xml below as such. I've also included a gif illustrating the issue.

<types>
    <members>*</members>
    <name>CustomTab</name>
</types>

Regards, Frank

x6Z2pSFFXX

vignaesh01 commented 4 years ago

Hi @PotSeht , Thanks for your feedback. I get the issue. At present that how it is designed to work. Select all will always select all the contents irrespective of the filter. Let me think of a way to bring in the functionality you are asking for. BTW do you have any ideas on how the UI should be?

PotSeht commented 4 years ago

Hi @vignaesh01,

UI-wise, I think you've done an excellent job already. How it currently looks is very functional and looks good. The only thing I can think of is perhaps have the color scheme of the package generator be leveraged by the Color Theme of the IDE, just to provide consistency across the app? Just an idea.

Thanks for seeing as to whether that functionality is possible, I think it would definitely provide a better user experience.

RubenHalman commented 4 years ago

@vignaesh01 A lot of coworkers that are less tech savvy and would love to use your app are running into this issue.

Perhaps I can help creating an additional 3rd button 'Add selection'?

PawelWozniak commented 3 years ago

I also missing 'Add Selection' button. This would be usefull.