vignaesh01 / sfdx-package-generator

Salesforce Package.xml Generator Extension for VS Code
https://marketplace.visualstudio.com/items?itemName=VignaeshRamA.sfdx-package-xml-generator
Other
63 stars 31 forks source link

when selecting a metadatatype please dont jump view to the top. #35

Closed peternoges closed 3 years ago

peternoges commented 4 years ago

Hey,

Unfortunately after selecting any checkbox, including Dashboard, it jumps my screen to the top.

In my opinion the left pane should not be jumping to the top after a selection.

2020-04-27

I wanted to quickly select Dashboard and Document because they were both in view. However after clicking Dashboard it jumps to the top forcing me to take added steps of scrolling to Document again or searching for it.

JodieM commented 4 years ago

Yes, I agree.

stephenpstanley commented 4 years ago

It's good to see the right hand pane executing so you can get a view of what meta data items are being retrieved. A fix for this could be to implement two independently scrolling regions. This would solve both problems - the left hand region could stay where it is, and the right hand scrolling region could scroll to the top so you can see what has been retrieved for the selected meta data type

peternoges commented 4 years ago

It's good to see the right hand pane executing so you can get a view of what meta data items are being retrieved. A fix for this could be to implement two independently scrolling regions. This would solve both problems - the left hand region could stay where it is, and the right hand scrolling region could scroll to the top so you can see what has been retrieved for the selected meta data type

i believe my claim from april is about the left-pane, not the right-pane

stephenpstanley commented 4 years ago

@peternoges That's exactly what I was chiming in with so I'm somewhat surprised to see your thumbs down

There is only one region in the tool and it all scrolls up to the top, which I agree is annoying. I was proposing splitting the one pane in two, and stopping the left pane (in which the meta data type is selected) from scrolling.

I'm not sure how I could make my suggestion clearer to avoid an unjustified thumbs-down...

vignaesh01 commented 4 years ago

I have to split the 2 panes - each with its own dedicated scroll bar to fix this issue.

camisotro commented 4 years ago

Looking forward to a resolution to this. Would make the experience much faster and more pleasant!

davebuoso commented 4 years ago

The "jumping to the top" of the Metadata Types list is really annoying. The process of selection become really slow.

JodieM commented 3 years ago

Why was it closed? Was it fixed?

peternoges commented 3 years ago

Instead of scrolling to only be disappointed by a screen jump, we can use the search to hide non-relevant types ( thus no scrolling thus no screen jumps) but this is not a great solution because it requires typing for n Number of types.

Edit: I re-opened the issue, maybe we can solve it by https://github.com/vignaesh01/sfdx-package-generator/pull/50

JodieM commented 3 years ago

Yeah, nah, typing 100+ partial sentences is not a workaround. This needs to be fixed to make this extension usable.

vignaesh01 commented 3 years ago

Hi, I will come up with a fix soon.

On Thu, Dec 3, 2020 at 4:53 AM Peter Noges notifications@github.com wrote:

Reopened #35 https://github.com/vignaesh01/sfdx-package-generator/issues/35.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/vignaesh01/sfdx-package-generator/issues/35#event-4064817306, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDYPO6K6WM57CKFDWVXPSLSS3D53ANCNFSM4MSDPMGQ .

-- Thanks and Regards, Vignaesh Ram .A

peternoges commented 3 years ago

Hi, I will come up with a fix soon. On Thu, Dec 3, 2020 at 4:53 AM Peter Noges @.***> wrote: Reopened #35 <#35>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDYPO6K6WM57CKFDWVXPSLSS3D53ANCNFSM4MSDPMGQ . -- Thanks and Regards, Vignaesh Ram .A

hey @vignaesh01 happy New Year to you, would these two line changes solve the issue? See the pull request here https://github.com/vignaesh01/sfdx-package-generator/pull/50/commits/9ac04b19da4483023dda9ca344bc98c241194ca5 Thanks for your hard work and awesome vsc extension.

vignaesh01 commented 3 years ago

This issue has been fixed now in version 2.0.4. Thanks!