search

vigneshshettyin / Meetly

Meetly integrates meeting management and video conferencing under a single platform.
https://play.google.com/store/apps/details?id=com.vs.meetly
18 stars 17 forks source link

[Feature Request]: Shimmer Frame Layout for RecyclerViews #29

Closed aayushpathak11 closed 2 years ago

aayushpathak11 commented 2 years ago

Description

Whenever a Recycler View is loading from some API/Database , there may be a gap in between for loading time, I suggest that gap could be filled by shimmer effect so that it looks nice from user experience perspective.

Domain

Android (Kotlin)

Code of Conduct

github-actions[bot] commented 2 years ago

Hello @aayushpathak11,
Thank you for opening an issue. :octocat:
Check this guide before contributing.

aayushpathak11 commented 2 years ago

Hi @vigneshshettyin , I would like to work upon this issue.

vigneshshettyin commented 2 years ago

Hey, @aayushpathak11 assigning this issue to you.

aayushpathak11 commented 2 years ago

Hello @vigneshshettyin sir, sorry for the delay in work. It was due to some college commitments.

I have added Shimmer Layout in both Support Activity and Main Activity but I have a few doubts before making the PR.

Doubt 1) When I click on the Support Updates in the app, it shows me a blank screen. Recycler view is activated (as shimmer layout disappears) but nothing appears on the screen. I am attaching the screenshot of how it appears to me.

WhatsApp Image 2022-03-31 at 12 05 10 AM

Doubt 2) There is already a preloader in the app which does exactly the same thing of filling up the time while recyclerview is loading , So now as I have added shimmer layout they should be removed.

Doubt 3) There are more activities where recyclerview is present. Should I apply shimmer layout in all of them?

vigneshshettyin commented 2 years ago

Hey, @aayushpathak11 thanks for responding. Support updates are loaded from the firestorm. As there are not any entries present so, the data won't display there. The current preloader is present pls remove it from the codebase. Yes, add a shimmer layout to all the activities. Hope I have answered all your questions.