vigonometry / pe

0 stars 0 forks source link

Wrong error thrown on adding students #4

Open vigonometry opened 1 year ago

vigonometry commented 1 year ago

Details

On entering the add command with incomplete parameters it shows telegram/PHONE with a vastly different example from what the User Guide states.

To reproduce

Enter the command:

add n/Bellman s/o Balamurugan 

Expected behavior

The field containing the telegram handle should show telegram/TELEGRAM_HANDLE as indicated in the User Guide.

Screenshots / Screen recordings

Screenshot 2023-04-14 at 2.37.02 PM.png

System Details

soc-pe-bot commented 1 year ago

Team's Response

This should not be labelled as medium because it does not hinder the user's understanding. Secondly, keying in a valid phone number would also search for the user's username, if the user has set his telegram preferences properly. So, we disagree that it is of severity medium, and it should be low instead.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Would be better to show feedback as "Telegram: Damith" instead of "Phone: Damith"

image.png

The current feedback may cause confusion as it's not exactly phone number that is added.


[original: nus-cs2103-AY2223S2/pe-interim#1127] [original labels: severity.VeryLow type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I disagree that this is a duplicate bug as they occur in two separate workflows. The first one occurs in error handling where TELEGRAM_HANDLE is misnomered as PHONE.

The supposed "duplicate" occurs when there is a successful addition of an entry into the system. As these are unique paths, they should not be deemed duplicates.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** ![Screenshot 2023-04-18 at 12.06.13 PM.png](https://raw.githubusercontent.com/vigonometry/pe/main/files/db74ec79-653e-4c4c-9472-120ab5b5a1bd.png) This behavior falls clearly under the category FunctionalityBug as stated above. The behavior deviates from the user guide that specifies the command format. As such, I will not accept this being called a Feature Flaw.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ![Screenshot 2023-04-18 at 12.06.13 PM.png](https://raw.githubusercontent.com/vigonometry/pe/main/files/70d5dd57-4b84-4af3-b2fe-8fc57931831f.png) While I will accept a severity downgrade to Low, the developers should not trivialize the issue to a VeryLow status that is reserved purely for cosmetic issues. ![Screenshot 2023-04-18 at 12.11.31 PM.png](https://raw.githubusercontent.com/vigonometry/pe/main/files/52764857-560a-4331-85d9-e2c642bc2a8f.png) The constraints of the telegram handle are clearly stated as alphanumeric, but the examples that are given show string literals instead of phone numbers, so the expected user behavior would be to add a telegram handle instead of a phone number. Furthermore, it should not be left to the user to infer that phone number and telegram handle mean the same thing but rather should be something that was specified by the developers.