vigonometry / pe

0 stars 0 forks source link

Capitalization of first character of telegram handle allows for duplicate telegram handle entries #5

Open vigonometry opened 1 year ago

vigonometry commented 1 year ago

Details

On capitalizing the first character of the telegram handle, entries with duplicate telegram handles are allowed to be entered into the application.

To reproduce

Enter the command

add n/John Dei telegram/johndei e/e9182842@u.nus.edu a/311, Clementi Ave 2, #02-25 score/40 

followed by

add n/John Doe telegram/Johndei e/e9182832@u.nus.edu a/311, Clementi Ave 2, #02-25 score/40 

Expected behavior

Screenshots / Screen recordings

Screenshot 2023-04-14 at 2.40.15 PM.png

System Details

nus-pe-script commented 1 year ago

Team's Response

It is an intended behaviour as we accept the following for telegram: Telegram handle must be minimum 5 characters and maximum 32 characters. It can only contain alphanumeric characters and underscores.

Hence, capitalization are treated differently, as it should be clear that alphanumeric characters means capitalizations are treated differently.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]