vigonometry / pe

0 stars 0 forks source link

Add student Command: Slashes are not allowed within name parameter #6

Open vigonometry opened 1 year ago

vigonometry commented 1 year ago

Details

Slashes are not allowed in student name parameter when using add

To reproduce

Enter the command:

add n/John s/o Bae telegram/johnbae e/e9182842@u.nus.edu a/311, Clementi Ave 2, #02-25 score/40 

Expected behavior

The command accepts the student's name as valid since the User Guide only places the constraint of "maximum of 70 characters"

Screenshots / Screen recordings

Screenshot 2023-04-14 at 2.45.11 PM.png

System Details

nus-pe-bot commented 1 year ago

Team's Response

It is intended, but I agree we should have stated in the documentation. Thanks for your input.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** ![Screenshot 2023-04-18 at 6.24.40 PM.png](https://raw.githubusercontent.com/vigonometry/pe/main/files/298c15b6-362e-43c6-afa1-a9cbb7522cc9.png) Having taken a look at the definitions provided on the website, this does not seem to be a missing step, wrong information or a typo but much rather an oversight on the general characters that are allowed to be used. The lack of information on "characters" leads readers to believe that any valid character including apostrophes, slashes, CJK support (Chinese, Japanese Korean) should be accepted. Furthermore, the lack of accepting s/o or d/o as valid inputs excludes certain racial segments from being entries in the application. However I'm willing to accept if this is classified a `FeatureFlaw` or `FunctionalityBug`
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ![Screenshot 2023-04-18 at 6.36.26 PM.png](https://raw.githubusercontent.com/vigonometry/pe/main/files/722abdd5-2507-4358-8ce2-04cd21c17d9e.png) This should not be downgraded to a `severity.Low` bug since it causes the occasional inconvenience to the user by excluding names from certain racial segments from being entered into the application. However I will accept that this is a `NotInScope` bug as the features the developers have created outweigh this issue. This feature should still be considered as an enhancement or part of the design for future iterations.