vigoren
commented
1 year ago Hey sorry about the long delay in getting back to you.
Moons are an area that I want to rework to make it better or easier to set up. I think I got it set up to how you want it to be set up. What I changed
- Cycle Adjustment: I set this to 0.5 I have found that doing this will reduce/eliminate the phases appearing on multiple dates (more on why that happens below).
- New Moon Month and Day: I set this to
Yinyavr (Cold Moon) 15which will bump the full moon to be on the first of every month.
That is it in terms of changes, the next few years appear to have the full moon only on the first day of the month and all the other phases follow as expected.
Why phases can appear on more than one day has to do with math rounding when doing to computation on what phase should appear on what day. The 0.5 helps push that rounding error to be less of an issue.
I do plan on updating the moon stuff but I have a few other enhancements I am currently working on at the moment so not sure exactly when it will get looked at.
FeistyMango
Describe the bug I am setting up a Barovian lunar calendar where there are 12 months with 28 days in each month. I've excluded leap years for simplicity and I'm just trying to config it so that the 1st day of every month is a Full Moon as is described in the campaign module. In order to achieve this, I just declare the New moon on the 1st month 14th day.
I can somewhat get this to work correctly however as you move through the calendar months, you start seeing all sorts of issues where a phase icon may appear twice in two consecutive days, or the full moon starts to shift forward or backward over time. Not really sure what is the cause of this. It almost seems like there is a hard coded set of assumptions in using the calculations to place moon phases on the calendar. Either that, or it's operator error and I just can't figure it out. See attached images.
I also used Find the Culprit with just Simple Calendar enabled and the issue was still present.
To Reproduce Steps to reproduce the behavior:
Expected behavior With this setup, I would expect every month that the Full Moon land on the 1st of every month and a New month to be on the 14th every month. Additionally, I would expect the waxing/wanning icons to fall on the day in the middle a a 6 day period. See config json below
Screenshots
Foundry Information
{"exportVersion":2,"globalConfig":{},"permissions":{"id":"d043387f","addNotes":{"player":false,"trustedPlayer":false,"assistantGameMaster":false},"changeDateTime":{"player":false,"trustedPlayer":false,"assistantGameMaster":false},"reorderNotes":{"player":false,"trustedPlayer":false,"assistantGameMaster":false},"viewCalendar":{"player":true,"trustedPlayer":true,"assistantGameMaster":true},"changeActiveCalendar":{"player":false,"trustedPlayer":false,"assistantGameMaster":false}},"calendars":[{"id":"default","name":"Barovian Lunar Calendar","currentDate":{"year":750,"month":1,"day":5,"seconds":37653},"general":{"gameWorldTimeIntegration":"self","showClock":true,"noteDefaultVisibility":false,"postNoteRemindersOnFoundryLoad":true,"pf2eSync":true,"dateFormat":{"date":"MMMM DD, YYYY","time":"HH:mm:ss","monthYear":"MMMM YAYYYYYZ"},"compactViewOptions":{"controlLayout":"quick-increment"}},"leapYear":{"id":"c935d140","rule":"none","customMod":0},"months":[{"id":"d077a012","name":"Yinyavr (Cold Moon)","description":"","abbreviation":"Yin","numericRepresentation":1,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"6b50f517","name":"Fenravr (Wolf Moon)","description":"","abbreviation":"Fen","numericRepresentation":2,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"ea0f65f9","name":"Martavr (Raven Moon)","description":"","abbreviation":"Mar","numericRepresentation":3,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"55c7d7a5","name":"Prylla (Rain Moon)","description":"","abbreviation":"Pry","numericRepresentation":4,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"4b9fff78","name":"Mada (Maid Moon)","description":"","abbreviation":"Mad","numericRepresentation":5,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"474f9395","name":"Eyun (Summer Moon)","description":"","abbreviation":"Eyu","numericRepresentation":6,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"e203bfa6","name":"Eyul (War Moon)","description":"","abbreviation":"Eyu","numericRepresentation":7,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"54b8791b","name":"Ugavr (Wine Moon)","description":"","abbreviation":"Uga","numericRepresentation":8,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"a2899380","name":"Sintavr (Harvest Moon)","description":"","abbreviation":"Sin","numericRepresentation":9,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"309e6737","name":"Ottyavr (Hunter's Moon)","description":"","abbreviation":"Ott","numericRepresentation":10,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"78c36c","name":"Neyavr (Rot Moon)","description":"","abbreviation":"Ney","numericRepresentation":11,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"cf7866f9","name":"Dekavr (Winter Moon)","description":"","abbreviation":"Dek","numericRepresentation":12,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null}],"moons":[{"id":"bf48f457","name":"The Moon","cycleLength":28,"firstNewMoon":{"yearReset":"none","yearX":0,"year":750,"month":0,"day":13},"phases":[{"name":"New Moon","length":1,"icon":"new","singleDay":true},{"name":"Waxing Crescent","length":6,"icon":"waxing-crescent","singleDay":false},{"name":"First Quarter","length":1,"icon":"first-quarter","singleDay":true},{"name":"Waxing Gibbous","length":6,"icon":"waxing-gibbous","singleDay":false},{"name":"Full Moon","length":1,"icon":"full","singleDay":true},{"name":"Waning Gibbous","length":6,"icon":"waning-gibbous","singleDay":false},{"name":"Last Quarter","length":1,"icon":"last-quarter","singleDay":true},{"name":"Waning Crescent","length":6,"icon":"waning-crescent","singleDay":false}],"color":"#ffffff","cycleDayAdjust":0}],"noteCategories":[],"seasons":[{"id":"65a44e19","name":"Winter 3","description":"","startingMonth":1,"startingDay":0,"color":"#00d5ff","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"66a5be01","name":"Spring 1","description":"","startingMonth":2,"startingDay":14,"color":"#258e25","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"fe747fca","name":"Spring 2","description":"","startingMonth":4,"startingDay":0,"color":"#258e25","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"4a4402cd","name":"Spring 3","description":"","startingMonth":5,"startingDay":14,"color":"#f5e000","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"32561040","name":"Summer 1","description":"","startingMonth":6,"startingDay":20,"color":"#f02400","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"44e5fc49","name":"Fall 1","description":"","startingMonth":7,"startingDay":0,"color":"#b12e2e","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"835ef64d","name":"Fall 2","description":"","startingMonth":7,"startingDay":14,"color":"#b1692e","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"2c05eddd","name":"Fall 3","description":"","startingMonth":8,"startingDay":14,"color":"#b1692e","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"83cf471","name":"Fall 4","description":"","startingMonth":9,"startingDay":0,"color":"#b99946","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"83584861","name":"Winter 1","description":"","startingMonth":10,"startingDay":14,"color":"#0091ff","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"cb7a9413","name":"Winter 2","description":"","startingMonth":11,"startingDay":14,"color":"#024cf7","icon":"none","sunriseTime":0,"sunsetTime":0}],"time":{"id":"5db8207f","hoursInDay":24,"minutesInHour":60,"secondsInMinute":60,"gameTimeRatio":1,"unifyGameAndClockPause":false,"updateFrequency":1},"weekdays":[{"abbreviation":"Va","id":"d39f720e","name":"Vasarnap","description":"","numericRepresentation":1,"restday":false},{"abbreviation":"He","id":"75f62c5d","name":"Hetfo","description":"","numericRepresentation":2,"restday":false},{"abbreviation":"Ke","id":"387c6d2","name":"Kedd","description":"","numericRepresentation":3,"restday":false},{"abbreviation":"Sz","id":"2ce1891c","name":"Szerda","description":"","numericRepresentation":4,"restday":false},{"abbreviation":"Cs","id":"ecbd0b87","name":"Csutorok","description":"","numericRepresentation":5,"restday":false},{"abbreviation":"Pe","id":"52468ff8","name":"Pentek","description":"","numericRepresentation":6,"restday":false},{"abbreviation":"Sz","id":"d7721e2","name":"Szombat","description":"","numericRepresentation":7,"restday":false}],"year":{"id":"e32775bc","numericRepresentation":750,"prefix":"","postfix":"","showWeekdayHeadings":true,"firstWeekday":0,"yearZero":1,"yearNames":[],"yearNamingRule":"default","yearNamesStart":0}},{"id":"default","name":"Barovian Lunar Calendar","currentDate":{"year":750,"month":1,"day":5,"seconds":0},"general":{"gameWorldTimeIntegration":"self","showClock":true,"noteDefaultVisibility":false,"postNoteRemindersOnFoundryLoad":true,"pf2eSync":true,"dateFormat":{"date":"MMMM DD, YYYY","time":"HH:mm:ss","monthYear":"MMMM YAYYYYYZ"},"compactViewOptions":{"controlLayout":"quick-increment"}},"leapYear":{"id":"c935d140","rule":"none","customMod":0},"months":[{"id":"d077a012","name":"Yinyavr (Cold Moon)","description":"","abbreviation":"Yin","numericRepresentation":1,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"6b50f517","name":"Fenravr (Wolf Moon)","description":"","abbreviation":"Fen","numericRepresentation":2,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"ea0f65f9","name":"Martavr (Raven Moon)","description":"","abbreviation":"Mar","numericRepresentation":3,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"55c7d7a5","name":"Prylla (Rain Moon)","description":"","abbreviation":"Pry","numericRepresentation":4,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"4b9fff78","name":"Mada (Maid Moon)","description":"","abbreviation":"Mad","numericRepresentation":5,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"474f9395","name":"Eyun (Summer Moon)","description":"","abbreviation":"Eyu","numericRepresentation":6,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"e203bfa6","name":"Eyul (War Moon)","description":"","abbreviation":"Eyu","numericRepresentation":7,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"54b8791b","name":"Ugavr (Wine Moon)","description":"","abbreviation":"Uga","numericRepresentation":8,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"a2899380","name":"Sintavr (Harvest Moon)","description":"","abbreviation":"Sin","numericRepresentation":9,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"309e6737","name":"Ottyavr (Hunter's Moon)","description":"","abbreviation":"Ott","numericRepresentation":10,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"78c36c","name":"Neyavr (Rot Moon)","description":"","abbreviation":"Ney","numericRepresentation":11,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null},{"id":"cf7866f9","name":"Dekavr (Winter Moon)","description":"","abbreviation":"Dek","numericRepresentation":12,"numericRepresentationOffset":0,"numberOfDays":28,"numberOfLeapYearDays":28,"intercalary":false,"intercalaryInclude":false,"startingWeekday":null}],"moons":[{"id":"bf48f457","name":"The Moon","cycleLength":28,"firstNewMoon":{"yearReset":"none","yearX":0,"year":750,"month":0,"day":13},"phases":[{"name":"New Moon","length":1,"icon":"new","singleDay":true},{"name":"Waxing Crescent","length":6,"icon":"waxing-crescent","singleDay":false},{"name":"First Quarter","length":1,"icon":"first-quarter","singleDay":true},{"name":"Waxing Gibbous","length":6,"icon":"waxing-gibbous","singleDay":false},{"name":"Full Moon","length":1,"icon":"full","singleDay":true},{"name":"Waning Gibbous","length":6,"icon":"waning-gibbous","singleDay":false},{"name":"Last Quarter","length":1,"icon":"last-quarter","singleDay":true},{"name":"Waning Crescent","length":6,"icon":"waning-crescent","singleDay":false}],"color":"#ffffff","cycleDayAdjust":0}],"noteCategories":[],"seasons":[{"id":"65a44e19","name":"Winter 3","description":"","startingMonth":1,"startingDay":0,"color":"#00d5ff","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"66a5be01","name":"Spring 1","description":"","startingMonth":2,"startingDay":14,"color":"#258e25","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"fe747fca","name":"Spring 2","description":"","startingMonth":4,"startingDay":0,"color":"#258e25","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"4a4402cd","name":"Spring 3","description":"","startingMonth":5,"startingDay":14,"color":"#f5e000","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"32561040","name":"Summer 1","description":"","startingMonth":6,"startingDay":20,"color":"#f02400","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"44e5fc49","name":"Fall 1","description":"","startingMonth":7,"startingDay":0,"color":"#b12e2e","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"835ef64d","name":"Fall 2","description":"","startingMonth":7,"startingDay":14,"color":"#b1692e","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"2c05eddd","name":"Fall 3","description":"","startingMonth":8,"startingDay":14,"color":"#b1692e","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"83cf471","name":"Fall 4","description":"","startingMonth":9,"startingDay":0,"color":"#b99946","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"83584861","name":"Winter 1","description":"","startingMonth":10,"startingDay":14,"color":"#0091ff","icon":"none","sunriseTime":0,"sunsetTime":0},{"id":"cb7a9413","name":"Winter 2","description":"","startingMonth":11,"startingDay":14,"color":"#024cf7","icon":"none","sunriseTime":0,"sunsetTime":0}],"time":{"id":"5db8207f","hoursInDay":24,"minutesInHour":60,"secondsInMinute":60,"gameTimeRatio":1,"unifyGameAndClockPause":false,"updateFrequency":1},"weekdays":[{"abbreviation":"Va","id":"d39f720e","name":"Vasarnap","description":"","numericRepresentation":1,"restday":false},{"abbreviation":"He","id":"75f62c5d","name":"Hetfo","description":"","numericRepresentation":2,"restday":false},{"abbreviation":"Ke","id":"387c6d2","name":"Kedd","description":"","numericRepresentation":3,"restday":false},{"abbreviation":"Sz","id":"2ce1891c","name":"Szerda","description":"","numericRepresentation":4,"restday":false},{"abbreviation":"Cs","id":"ecbd0b87","name":"Csutorok","description":"","numericRepresentation":5,"restday":false},{"abbreviation":"Pe","id":"52468ff8","name":"Pentek","description":"","numericRepresentation":6,"restday":false},{"abbreviation":"Sz","id":"d7721e2","name":"Szombat","description":"","numericRepresentation":7,"restday":false}],"year":{"id":"e32775bc","numericRepresentation":750,"prefix":"","postfix":"","showWeekdayHeadings":true,"firstWeekday":0,"yearZero":1,"yearNames":[],"yearNamingRule":"default","yearNamesStart":0}}],"notes":{"default":[{"name":"New Note","folder":"548UlTxhoCKhqNaC","flags":{"core":{"sheetClass":"foundryvtt-simple-calendar.NoteSheet"},"foundryvtt-simple-calendar":{"noteData":{"calendarId":"default","startDate":{"year":750,"month":1,"day":5,"hour":0,"minute":0,"seconds":0},"endDate":{"year":750,"month":1,"day":5,"hour":0,"minute":0,"seconds":0},"allDay":true,"repeats":0,"order":0,"categories":[],"remindUsers":[]}},"scene-packer":{"hash":"8180498bb0026b10574555994d1f3860f98e23e3"}},"ownership":{"QX10ZeYBS8udRBR8":3,"Gp8sup0POr81PAwj":0,"mzmfcBD23kzOpftR":0,"67FyeQ5wZOn2UKQB":0,"O4lE6ZMmWvlMgtiq":0,"3I7HuKfnGcNDTfpL":0,"82FygCw2VpqWnxYn":0},"pages":[{"text":{"content":"","format":1},"name":"Details","_id":"Rfhz0uMzNovKbJqU","type":"text","title":{"show":true,"level":1},"image":{},"video":{"controls":true,"volume":0.5},"src":null,"system":{},"sort":0,"ownership":{"default":-1},"flags":{}}],"sort":0,"_stats":{"systemId":"dnd5e","systemVersion":"2.1.4","coreVersion":"10.291","createdTime":1675741987083,"modifiedTime":1675741987099,"lastModifiedBy":"QX10ZeYBS8udRBR8"},"_id":"Vs7DClZGckmlyDp8"}]}}Browser (please complete the following information):