vigoren / foundryvtt-simple-calendar

A simple calendar module for the FoundryVTT system
https://simplecalendar.info/
MIT License
48 stars 36 forks source link

Custom Time hours of Day Improper Functioning[BUG] #471

Open Shaolth opened 1 year ago

Shaolth commented 1 year ago

Describe the bug Unsure outright if this overall problem is exactly a Bug and/or feature request so please forgive me though most of this module does exactly as I'd hope minus a critical part involving a custom TIME system.

To explain; I am able to set the custom Hours in a day to what I want; 28 hours in a day, 60 seconds an hour, 60 minutes an hour. Great! The problem elsewise? 1) It forces a time of "00:00". It does NOT allow what my Calendar/Time system has of "28:59" --> "01:00". I am forced to play it as "27:59" --> "00:00"... Which isn't the worse if it wasn't for issue 2...

2) The Calendar no matter how I tried to set it up; FORCES/Assumes the following: Dawn = "01:00:00"; Midday = "14:00:00", Dusk = "15:00:00" and Midnight = "00:00:00". This... is utterly wrong. I was trying to use my custom system along the lines of: Hour 28 - 02 = Dawn (28:00:00 --> 02:00:00) Hour 02 - 14 = "Day" ((02:00:00 --> 14:00:00 | 12 hours total of daylight so I should be able to set mid-day to.. hour 8 // 08:00:00 )) Hour 14 - 16 = "Dusk" (14:00:00 --> 16:00:00 | 2 hour transition from Daylight to darkness is my intent) Hour 16 - 28 = "Night" (16:00:00 --> 28:00:00 || 12 hours total of Night/Darkness; which "Midnight" could either be by design = 27:00:00 to 28:00:00 instead of 28:00:00 --> 01:00:00 because that conflicts Dawn))

I tried to uncheck the option in the extra module "SmallTime" to sync with Simple Calendar but this does not fix it and only changes that clock to 24 hour.

I have SimpleCalendar General Settings "Game World Time Intergration" Set to Mixed; but nothing else seems to work.

Testing a bit, it seems generally that it goes from 27:59:59 --> 00:00:00... And that ends up being a problem in itself.

Is there a way to EXCLUDE 00 to go straight to 01 and instead include 28:59:59 --> 01:00:00 ? And to somehow have it sync/work to customize when the Transition of the day/night/dawn/dusk cycle is for such custom hours? Cause unlike Planet Earth using like 6 AM or so for dawn/sunrise... A custom fantasy world of mine has different where the aforementioned is used and it would mean a lot to be able to work it.

Everything else? custom days per week, days per month, month per year, etc? Works beautiful, even the seasons is all as expected! It's just that time fragment of the hours and time!

To Reproduce Steps to reproduce the behavior: 1: Change hours in a in a day under Time Settings to custom hour above 24. 2: Change UI Calendar's active time to that cap to see it set to hour 0 // 00:00:00.

Expected behavior I expected it to be able to transition from 28:59:59 to 01:00:00; and exclude 00:00:00 for a custom time system as well being able to modify when dawn/dusk are at what hours that seem to sync with other modules such as SmallTime.

Screenshots (https://prnt.sc/WfTGl4ry4uVi)

Foundry Information

Browser (please complete the following information):

Additional context Whether a Bug or Intended and a feature request, insight to this and possible resolution would be vastly appreciated. Thank you!

vigoren commented 1 year ago

Hey sorry about the long delay in getting back to you about this (had a couple months of medical issues).

You can modify when dawn and dusk are. The settings for that are under the seasons configuration. Those times are tied to seasons so you can have gradual transitions between dawn and dusk times between seasons for the year. That should hopefully allow you to set those times correctly.

Charging the starting time for a day from 00:00:00 to 01:00:00 would be a feature request and is something I can look at adding. My thoughts are allowing for a time offset that can be set to have the day start at any time a person would want and it would adjust the end time accordingly.