vigoren / foundryvtt-simple-calendar

A simple calendar module for the FoundryVTT system
https://simplecalendar.info/
MIT License
48 stars 36 forks source link

[BUG] Syncing with PF2E world clock forces Gregorian leap year. #631

Open The-BirdGod opened 2 months ago

The-BirdGod commented 2 months ago

Describe the bug When turning on "Pathfinder 2E: World Time Sync", Leap Year Rule is forced on, even though I am using a custom calendar in Simple Calendar

To Reproduce Steps to reproduce the behavior:

  1. Make any calendar
  2. Turn on "Pathfinder 2E: World Time Sync"
  3. Leap Year Rule becomes locked to "Gregorian"

Expected behavior Ability to have no Leap Years with a custom calendar while syncing with the game clock, so timed effect expire on their own.

Screenshots image

Foundry Information

Browser (please complete the following information):

Additional context Main reason this is an issue is because when Simple Calendar is not synced with the game clock, the module SmallTime goes out of sync with Simple Calendar, even though it's set to take it's information from it. I've also opened an issue for that module.

The-BirdGod commented 2 months ago

Update: seems SmallTime's author has already had this issue raised. It's either a system issue or an issue with Simple Calendar's time sync (author's words, not mine). The other user was also on PF2E, and it seems like they were running both the Golarion and Gregorian calendars, which have leap years. Link for clarity.

https://github.com/unsoluble/smalltime/issues/202